Merge ~kissiel/checkbox-ng:fix-1853392-crash-on-reports into checkbox-ng:master

[Maciej Kisielewski]

xlsx: fix crash when resources were missing fields

Previously the xlsx exporter blindly accessed fields that may have not been there, due to - for instance - crash in the resource job or misformat of some information yielded by the resource job's binary. This patch uses .get()s on thosde dictionaries, so the worst case scenario is missing information in the report instead of a Checkbox crash.

Tested on good, broken, and sort-of-lacking resource jobs.

[Sylvain Pineau (sylvain-pineau)]

LGTM, thx

review: Approve

diff --git a/plainbox/impl/exporter/xlsx.py b/plainbox/impl/exporter/xlsx.py
index eb4253a..0a235f0 100644
--- a/plainbox/impl/exporter/xlsx.py
+++ b/plainbox/impl/exporter/xlsx.py
@@ -230,7 +230,7 @@ class XLSXSessionStateExporter(SessionStateExporterBase):
                 hw_info['bios'] = result.pop()
         resource = 'com.canonical.certification::cpuinfo'
         if resource in data['resource_map']:
-            result = ['{} x {}'.format(i['model'], i['count'])
+            result = ['{} x {}'.format(i.get('model'), i.get('count'))
                       for i in data["resource_map"][resource]]
             if result:
                 hw_info['processors'] = result.pop()
@@ -268,7 +268,8 @@ class XLSXSessionStateExporter(SessionStateExporterBase):
                 hw_info['vram'] = '{} MiB'.format(vram)
         resource = 'com.canonical.certification::meminfo'
         if resource in data['resource_map']:
-            result = ['{} GiB'.format(format(int(i['total']) / 1073741824,
+            result = ['{} GiB'.format(format(int(
+                i.get('total', 0)) / 1073741824,
                       '.1f')) for i in data["resource_map"][resource]]
             if result:
                 hw_info['memory'] = result.pop()