Merge lp:~kirkland/launchpad/532624 into lp:launchpad

[Deryck Hodge]

Change the person bugs page link of "show package report" to the more intuitive "list subscribed packages."

[Deryck Hodge (deryck)]

The code is simple and looks good. Thanks for fixing an affected test, too. I'll run this through ec2 just to make sure all tests are covered.

You'll also need to get a UI reviewer to approve the change. Ping noodles775 or sinzui in #launchpad-reviews on Freenode for this.

Thanks again for fixing this!

Cheers,
deryck

review: Approve (code)

[Deryck Hodge (deryck)]

Hi, Dustin.

Do you want me to ping a UI reviewer for this for you? Or would you like to follow up with them about UI review. It's a minor change, I realize, but still it would be nice to get a UI reviewer ack on this.

Cheers,
deryck

[Dustin Kirkland  (kirkland)]

On Fri, Mar 19, 2010 at 6:41 AM, Deryck Hodge
<email address hidden> wrote:
> Do you want me to ping a UI reviewer for this for you?  Or would you like to follow up with them about UI review.  It's a
> minor change, I realize, but still it would be nice to get a UI reviewer ack on this.

Hi Deryck-

It's a trivial bug, with a patch, and a branch, and a merge proposal.
  Honestly, I'd think that my job as a drive by community contributor
should be over at this point (bug filed, source branched, fixed, merge
proposed).

Ideally, you guys (Launchpad, UI, whoever), take it upstream, and roll
it out in a future release.

I don't really have the time or inclination to drive it further than this.

:-Dustin

[Deryck Hodge (deryck)]

Different people have different expectations about how long they want to stick with a branch to see it landed, which is why I asked.

I'll take it from here. Thanks for the patch.

Cheers,
deryck

[Curtis Hovey (sinzui)]

review: Approve (ui)

=== modified file 'lib/lp/registry/browser/person.py'
--- lib/lp/registry/browser/person.py	2010-03-05 14:18:18 +0000
+++ lib/lp/registry/browser/person.py	2010-03-05 19:25:28 +0000
@@ -754,7 +754,7 @@
         return Link('+assignedbugs', text, site='bugs', summary=summary)
 
     def softwarebugs(self):
-        text = 'Show package report'
+        text = 'List subscribed packages'
         summary = (
             'A summary report for packages where %s is a bug supervisor.'
             % self.context.displayname)

=== modified file 'lib/lp/registry/stories/person/xx-person-bugs.txt'
--- lib/lp/registry/stories/person/xx-person-bugs.txt	2010-02-10 12:14:41 +0000
+++ lib/lp/registry/stories/person/xx-person-bugs.txt	2010-03-05 19:25:28 +0000
@@ -159,7 +159,7 @@
     http://bugs.launchpad.dev/~name12/+subscribedbugs
     >>> print anon_browser.getLink('List all related bugs').url
     http://bugs.launchpad.dev/~name12
-    >>> print anon_browser.getLink('Show package report').url
+    >>> print anon_browser.getLink('List subscribed packages').url
     http://bugs.launchpad.dev/~name12/+packagebugs
     >>> anon_browser.open('http://launchpad.dev/~name12/+commentedbugs')
     >>> print anon_browser.getLink('List assigned bugs').url