Merge lp:~kiril-vladimiroff/cloud-init/cloudsigma-lack-of-ssh-key into lp:~cloud-init-dev/cloud-init/trunk

Proposed by Kiril Vladimiroff
Status: Rejected
Rejected by: Scott Moser
Proposed branch: lp:~kiril-vladimiroff/cloud-init/cloudsigma-lack-of-ssh-key
Merge into: lp:~cloud-init-dev/cloud-init/trunk
Diff against target: 11 lines (+1/-1)
1 file modified
cloudinit/sources/DataSourceCloudSigma.py (+1/-1)
To merge this branch: bzr merge lp:~kiril-vladimiroff/cloud-init/cloudsigma-lack-of-ssh-key
Reviewer Review Type Date Requested Status
cloud-init Commiters Pending
Review via email: mp+228331@code.launchpad.net

Description of the change

Right now CloudSigma's datasource expects that the user will have defined ssh_public_key in his server context or at least that he will not delete the key (it's there by default for each user). If he does it however, the datasource can't get it, does not assume that this key could not be there and therefore the datasource does not work.

This merge proposal just fixes that issue :)

To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :

Hello,
Thank you for taking the time to contribute to cloud-init. Cloud-init has moved its revision control system to git. As a result, we are marking all bzr merge proposals as 'rejected'. If you would like to re-submit this proposal for review, please do so by following the current HACKING documentation at http://cloudinit.readthedocs.io/en/latest/topics/hacking.html .

I think this might be still valid, so please do re-submit.

Scott

Unmerged revisions

988. By Kiril Vladimiroff

CloudSigma data source should not rely on the existence of ssh_public_key

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'cloudinit/sources/DataSourceCloudSigma.py'
2--- cloudinit/sources/DataSourceCloudSigma.py 2014-05-30 18:50:57 +0000
3+++ cloudinit/sources/DataSourceCloudSigma.py 2014-07-25 14:50:59 +0000
4@@ -100,7 +100,7 @@
5 self.vendordata_raw = server_context["vendor_data"]["cloudinit"]
6
7 self.metadata = server_context
8- self.ssh_public_key = server_meta['ssh_public_key']
9+ self.ssh_public_key = server_meta.get('ssh_public_key', '')
10
11 return True
12