Merge lp:~kill-animals/ubuntu-docviewer-app/1364248-change-some-listitems-to-Subtitled into lp:ubuntu-docviewer-app/trunk

Proposed by Kill Animals
Status: Merged
Approved by: Andrew Hayzen
Approved revision: 30
Merged at revision: 31
Proposed branch: lp:~kill-animals/ubuntu-docviewer-app/1364248-change-some-listitems-to-Subtitled
Merge into: lp:ubuntu-docviewer-app/trunk
Diff against target: 33 lines (+6/-6)
1 file modified
ubuntu-docviewer-app.qml (+6/-6)
To merge this branch: bzr merge lp:~kill-animals/ubuntu-docviewer-app/1364248-change-some-listitems-to-Subtitled
Reviewer Review Type Date Requested Status
Andrew Hayzen (community) Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+235399@code.launchpad.net

Commit message

Changed the details list items with long text contents to Subtitled, this way they can see the full string

Description of the change

Changed the details list items with long text contents to Subtitled, this way they can see the full string

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Andrew Hayzen (ahayzen) wrote :

Looks good, you can now read the full path of the file and the modification date :) Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-docviewer-app.qml'
2--- ubuntu-docviewer-app.qml 2014-03-13 18:11:54 +0000
3+++ ubuntu-docviewer-app.qml 2014-09-21 09:02:55 +0000
4@@ -75,23 +75,23 @@
5 Column {
6 width: parent.width
7
8- ListItem.SingleValue {
9+ ListItem.Subtitled {
10 text: i18n.tr("Location")
11- value: file.path
12+ subText: file.path
13 }
14 ListItem.SingleValue {
15 text: i18n.tr("Size")
16 value: Utils.printSize(file.size)
17 }
18
19- ListItem.SingleValue {
20+ ListItem.Subtitled {
21 text: i18n.tr("Created")
22- value: qsTr("%1").arg(file.creationTime.toLocaleString(Qt.locale()))
23+ subText: qsTr("%1").arg(file.creationTime.toLocaleString(Qt.locale()))
24 }
25
26- ListItem.SingleValue {
27+ ListItem.Subtitled {
28 text: i18n.tr("Last modified")
29- value: qsTr("%1").arg(file.lastModified.toLocaleString(Qt.locale()))
30+ subText: qsTr("%1").arg(file.lastModified.toLocaleString(Qt.locale()))
31 }
32
33 ListItem.SingleValue {

Subscribers

People subscribed via source and target branches