lp:~kill-animals/music-app/remix-nowplaying-code-refinement+proper-scaling

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp:music-app/remix

Victor Thompson: Disapprove on 2014-10-15

Ubuntu Phone Apps Jenkins Bot: Needs Fixing (continuous-integration) on 2014-10-15

Diff: 557 lines (+191/-225)

4 files modified

MusicNowPlaying.qml (+191/-208)
common/MusicPage.qml (+0/-4)
tests/autopilot/music_app/__init__.py (+0/-11)
tests/autopilot/music_app/tests/test_music.py (+0/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

665. By Kill Animals on 2014-10-15

wrestling with syntax. Sorry jenkins.

664. By Kill Animals on 2014-10-15

took out the commented code altogether; the syntax issues behoove me.

663. By Kill Animals on 2014-10-15

fixed python syntax

662. By Kill Animals on 2014-10-15

Deprecated a test that relied on ubuntuSliderShape, as that no longer exists, now that we are using a slider. I commented it out, and appended a Fixme. The test was seeking, and I tested that myself, to which it is working. I also merged with trunk.

661. By Kill Animals on 2014-10-11

Added visible: !isListView

Thanks vic!

660. By Kill Animals on 2014-10-11

Merged with :submit

659. By Kill Animals on 2014-10-11

Recommit to use a proper screenshot: http://i.imgur.com/WqIBBs9.png
Tested on Emulator

As said, If the labels start touching eachother, the album label hides. So smaller devices have a bit more wiggle room with portrait mode before things start looking off.

The controls are anchored to the bottom, and the labels are evenly spaced out in between (with proper margins)

658. By Kill Animals on 2014-10-11

http://i.imgur.com/YhewwHc.png

Anchored the labels to be situated in between the controls/slider, and the blurred image. The app should now scale well for portrait configurations. I also made the album label only visible, if there is enough space to fit it. This is just in case of a smaller device using this.

657. By Kill Animals on 2014-10-09

Minor adjustments

656. By Kill Animals on 2014-10-09

Minor Adjustments