Code review comment for lp:~kiithsacmp/stellarium/glexperiment

treaves (treaves) wrote :

This simply fails to compile.

Looking into it more, there are several issues:
- GL_RGBA32F on Mac is GL_RGBA32F_ARB. It looks like this may be due to Apple not having updated their include files to reflect that it is now standard, and not experimental.

- SolarSystem.cpp:937:12: error: variable length array of non-POD element type 'Vec4f' (aka 'Vector4<float>')
- SolarSystem.cpp:940:22: error: variable length array of non-POD element type 'Mat4d' (aka 'Matrix4<double>')

For those last two, you need to do heap allocation, or refactor the code to use a Qt structure (QVector perhaps?).

Once those are taken care of, it compiles and runs (I used the heap allocation because it was the most expedient solution). However. On my very new, very expensive, very high end computer, the frame rate goes from 75 for the 0.11.4 release we just made, to 15. That's a phenomenal decrease in performance! I'll try it tomorrow on my crappy work machine running Ubuntu, to see how it is there. Is this kind of performance decrease expected?

review: Needs Fixing

« Back to merge proposal