Unity Greeter

Merge lp:~khurshid-alam/unity-greeter/vala-fix-0.43 into lp:unity-greeter

  1. vala-fix-0.43
  2. Merge into trunk
Proposed by Khurshid Alam
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 2458
Merged at revision: 2458
Proposed branch: lp:~khurshid-alam/unity-greeter/vala-fix-0.43
Merge into: lp:unity-greeter
Diff against target: 12 lines (+1/-1)
1 file modified
src/list-stack.vala (+1/-1)
To merge this branch: bzr merge lp:~khurshid-alam/unity-greeter/vala-fix-0.43
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Sebastien Bacher Pending
Review via email: mp+363878@code.launchpad.net

Commit message

src/list-stack.vala: Fix build with vala 0.43.x

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Look good.

I'd just have used `children.last ().prev != null` though here.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/list-stack.vala'
2--- src/list-stack.vala 2016-08-02 19:20:40 +0000
3+++ src/list-stack.vala 2019-03-01 18:50:47 +0000
4@@ -72,7 +72,7 @@
5
6 return_if_fail (children != null);
7
8- unowned List<Gtk.Widget> prev = children.last ().prev;
9+ unowned List<weak Gtk.Widget> prev = children.last ().prev;
10 if (prev != null)
11 (prev.data as GreeterList).greeter_box.pop ();
12 }

Subscribers

People subscribed via source and target branches