Code review comment for lp:~khurshid-alam/unity-control-center/fix-image-preview

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work

The corresponding upstream change for the user panel is
https://gitlab.gnome.org/GNOME/gnome-control-center/commit/5c5d6087

Why didn't you take the other parts of the change? The "non-const" seems needed since now mime_type is the return of a g_strdup. The free call is also needed otherwise you leak the dup-ed string

The appareance capplet code is in the same case

review: Needs Fixing

« Back to merge proposal