Merge ~khurshid-alam/ubuntu/+source/ubuntu-settings:terminal-headerbar into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master

Proposed by Khurshid Alam on 2019-02-11
Status: Merged
Approved by: Didier Roche on 2019-02-13
Approved revision: b8607ab7aadc34a32bb233c3d654b9a76e31b78c
Merged at revision: 17ad9ef0b3a9759c12ac4d2fa7a052d3f4edafec
Proposed branch: ~khurshid-alam/ubuntu/+source/ubuntu-settings:terminal-headerbar
Merge into: ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
Diff against target: 14 lines (+3/-0)
1 file modified
debian/ubuntu-settings.gsettings-override (+3/-0)
Reviewer Review Type Date Requested Status
Didier Roche 2019-02-11 Approve on 2019-02-13
Review via email: mp+362989@code.launchpad.net

Commit message

Do not use headerbar for gnome-terminal under Unity. Fixes LP: #1815479

To post a comment you must log in.
Alberts Muktupāvels (muktupavels) wrote :

Should not Unity specific overrides be moved to unity source package?

Khurshid Alam (khurshid-alam) wrote :

No. It should move into unity-settings (https://code.launchpad.net/unity-settings), but my request to upload that was denied and I was asked to work with ubuntu-settings instead.

Alberts Muktupāvels (muktupavels) wrote :

I don't see any need for extra / new package for settings...

Unity settings/overrides are needed only if Unity is installed so it makes perfect sense if unity-settings.gsettings-override is provided / installed by unity.

Anyway I was just only sharing my opinion. :)

Khurshid Alam (khurshid-alam) wrote :

@muktupavels

It's not just gsettings but other things like different lightdm user name on iso, mime-types, overrides in /etc, /use/share etc and unity itself may not be the right place for all of it. That's what other desktop-sessions does, mate has mate-session, budgie has lots tweaks & overrides (https://github.com/UbuntuBudgie/budgie-desktop-environment). I actually created that package because Budgie-dev and Martin Wimpress recommended such.

Didier Roche (didrocks) wrote :

LGTM, merging, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/ubuntu-settings.gsettings-override b/debian/ubuntu-settings.gsettings-override
2index 38f336d..fdfef4b 100644
3--- a/debian/ubuntu-settings.gsettings-override
4+++ b/debian/ubuntu-settings.gsettings-override
5@@ -189,6 +189,9 @@ active = true
6 [org.gnome.settings-daemon.plugins.media-keys:Unity]
7 screensaver = '<Control><Alt>l'
8
9+[org.gnome.Terminal.Legacy.Settings:Unity]
10+headerbar = false
11+
12 #############################################
13 # communitheme specific session for testers #
14 #############################################

Subscribers

People subscribed via source and target branches