Merge ~khurshid-alam/ubuntu/+source/ubuntu-settings:nemo-desktop into ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master

Proposed by Khurshid Alam on 2019-02-04
Status: Merged
Approved by: Didier Roche on 2019-02-19
Approved revision: f4917ddd7ae80c6e05a5509807fb20234466adb1
Merge reported by: Didier Roche
Merged at revision: f4917ddd7ae80c6e05a5509807fb20234466adb1
Proposed branch: ~khurshid-alam/ubuntu/+source/ubuntu-settings:nemo-desktop
Merge into: ~ubuntu-desktop/ubuntu/+source/ubuntu-settings:master
Diff against target: 15 lines (+4/-0)
1 file modified
debian/ubuntu-settings.gsettings-override (+4/-0)
Reviewer Review Type Date Requested Status
Didier Roche 2019-02-04 Approve on 2019-02-19
Review via email: mp+362663@code.launchpad.net

Commit message

Use nemo-desktop to draw desktop icons under Unity. Fixes LP: #1814506

Since nautilus will still be default file-manager we disable auto-mount with nemo here.

Description of the change

Nemo action files

1) Adds a context menu "change background" which opens unity-control-center-appearance.

2) When user clicks on a image on Desktop, it adds a context menu set as wallpaper.

To post a comment you must log in.
Didier Roche (didrocks) wrote :

The settings override is the correct place for this. However, I feel the autostart for nemo doesn't belong here.
Especially, this would be installed in every ubuntu installation, and we don't really want it.

I think this should rather be in the unity-session package. WDYT?

review: Needs Fixing
Khurshid Alam (khurshid-alam) wrote :

unity-session derives from gnome-session. Would that be ok ?

Alberts Muktupāvels (muktupavels) wrote :

Move from gnome-session to unity? If unity-session would be part of unity then it might be easier to update things, no? Now it it looks like you have make changes in many/multiple places and in the end these changes makes sense only if unity is installed.

f4917dd... by Khurshid Alam on 2019-02-13

Use nemo-desktop to draw desktop icons under Unity. Fixes LP: #1814506

Since nautilus will still be default file-manager we disable auto-mount with nemo here.

Khurshid Alam (khurshid-alam) wrote :

@didrocks

Ah, I see, you are talking about unity-session install file. Yes it seems more appropriate.

I have now moved autostart and action files to unity-session install. See here https://code.launchpad.net/~khurshid-alam/ubuntu/+source/gnome-session/+git/gnome-session/+merge/363153

And I force pushed this with only gsettings override.

Khurshid Alam (khurshid-alam) wrote :

@muktupavels

I will try to decouple unity-session and other unity components next cycle. But other unity components should move to git first, so that our ubuntu-unity seed can work without breaking things.

Didier Roche (didrocks) wrote :

+1 LGTM. I'll give a build test and sponsor

review: Approve
Didier Roche (didrocks) wrote :

This is now merged. Unfortunately, I didn't notice that you changed the branch and kept your master with the actions. So, I just did another upload (19.04.2) to remove those.
Marking as merged manually thus! Thanks for this.

Khurshid Alam (khurshid-alam) wrote :

Yes I forgot to delete the master branch. I just made that for ppa. But Thanks for fixing that.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/ubuntu-settings.gsettings-override b/debian/ubuntu-settings.gsettings-override
2index fdfef4b..e198d2c 100644
3--- a/debian/ubuntu-settings.gsettings-override
4+++ b/debian/ubuntu-settings.gsettings-override
5@@ -163,6 +163,10 @@ mouse-button-modifier = '<Alt>'
6 trash-icon-visible = false
7 volumes-visible = false
8
9+[org.cinnamon.desktop.media-handling:Unity]
10+automount = false
11+automount-open = false
12+
13 [org.gnome.desktop.interface:Unity]
14 gtk-theme = "Ambiance"
15 icon-theme = "ubuntu-mono-dark"

Subscribers

People subscribed via source and target branches