Merge lp:~khurshid-alam/notify-osd/fix-gnotification-icon into lp:notify-osd

Proposed by Khurshid Alam
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 509
Merged at revision: 509
Proposed branch: lp:~khurshid-alam/notify-osd/fix-gnotification-icon
Merge into: lp:notify-osd
Diff against target: 18 lines (+8/-0)
1 file modified
src/stack.c (+8/-0)
To merge this branch: bzr merge lp:~khurshid-alam/notify-osd/fix-gnotification-icon
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Review via email:

This proposal supersedes a proposal from 2019-08-20.

Commit message

Support 'image-path' as hint

Both freedesktop notification ( spec & Gnotification use image-path as hint where notify-osd only uses image_path.

As a result when one uses themed icon with Gnotification it doesn't show the icon. Support for themed icon landed in

Fixes LP: #1840741

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks fine to me, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/stack.c'
2--- src/stack.c 2016-04-15 02:08:31 +0000
3+++ src/stack.c 2019-11-29 11:32:20 +0000
4@@ -760,6 +760,14 @@
5 else
6 g_warning ("image_path hint is not a string\n");
7 }
8+ else if ((data = (GValue*) g_hash_table_lookup (hints, "image-path")))
9+ {
10+ g_debug("Using image-path hint\n");
11+ if ((data && G_VALUE_HOLDS_STRING (data)))
12+ bubble_set_icon (bubble, g_value_get_string(data));
13+ else
14+ g_warning ("image-path hint is not a string\n");
15+ }
16 else if (icon && *icon != '\0')
17 {
18 g_debug("Using icon parameter\n");


People subscribed via source and target branches