Code review comment for lp:~khurshid-alam/indicator-sound/gicon-regression-fix

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your work, unsure the glib behaviour change can be described as 'regression' and that they plan to change the behaviour though. The test here should be adapted rather than commented out (and if you do you need to comment them, then there should at least be a code comment describing what needs to be fixed/changed later)

review: Needs Fixing

« Back to merge proposal