Code review comment for lp:~khadgaray/unity-lens-applications/fix-lockdown

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

I would rather the check happening when the lens is started and then listening to the key changing than after you did a search and ready to activate it.

In that case, we should display a friendly message to the user rather than afterwards :)

Also yeah, as told on IRC, the dependency should be specified directly. And it needs tests ;)

review: Needs Fixing

« Back to merge proposal