Merge lp:~khadgaray/unity-lens-applications/fix-lockdown into lp:unity-lens-applications

[Ritesh Khadgaray]

Allows an admin to disable command run dialog based on gnome security policies.

[Mikkel Kamstrup Erlandsen (kamstrup)]

This adds a hard runtime dep on the org.gnome.desktop.lockdown schema. Does this imply a new dependency for the package as well?

review: Needs Information

[Ritesh Khadgaray (khadgaray)]

> This adds a hard runtime dep on the org.gnome.desktop.lockdown schema. Does
> this imply a new dependency for the package as well?

Unity already depends on this via libgnome-desktop-3-4, which needs gsettings-desktop-schemas.

-- ritz

[Didier Roche-Tolomelli (didrocks)]

I would rather the check happening when the lens is started and then listening to the key changing than after you did a search and ready to activate it.

In that case, we should display a friendly message to the user rather than afterwards :)

Also yeah, as told on IRC, the dependency should be specified directly. And it needs tests ;)

review: Needs Fixing

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:287
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~khadgaray/unity-lens-applications/fix-lockdown/+merge/113251/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-lens-applications-ci/3/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-applications-raring-amd64-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-applications-raring-armhf-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-applications-raring-i386-ci/3/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-lens-applications-ci/3/rebuild

review: Needs Fixing (continuous-integration)

[Didier Roche-Tolomelli (didrocks)]

Didn't get any feedback. Rejecting due to aging MP

Unmerged revisions

287. By Ritesh Khadgaray on 2012-07-03

add lockdown support to disable commandline (LP# 813895)

=== modified file 'src/daemon.vala'
--- src/daemon.vala	2012-04-23 13:58:42 +0000
+++ src/daemon.vala	2012-07-03 16:28:26 +0000
@@ -997,6 +997,12 @@
       }
       else
       {
+          Settings lockdown = new Settings ("org.gnome.desktop.lockdown");
+          if (uri.has_prefix ("unity-runner://") && lockdown.get_boolean ("disable-command-line")) {
+            warning ("disabled by administrator");
+            return new Unity.ActivationResponse(Unity.HandledType.NOT_HANDLED);
+          }
+
           try {
             unowned string home_dir = GLib.Environment.get_home_dir ();
             Process.spawn_async (home_dir, args, null, SpawnFlags.SEARCH_PATH, null, null);