Merge lp:~kgunn72/unity-mir/mir-deb-bump-0.1.4 into lp:unity-mir

Proposed by kevin gunn
Status: Merged
Merged at revision: 171
Proposed branch: lp:~kgunn72/unity-mir/mir-deb-bump-0.1.4
Merge into: lp:unity-mir
Diff against target: 29 lines (+5/-3)
2 files modified
debian/control (+2/-2)
src/unity-mir/dbusscreen.cpp (+3/-1)
To merge this branch: bzr merge lp:~kgunn72/unity-mir/mir-deb-bump-0.1.4
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michael Terry (community) Needs Fixing
Gerry Boland (community) Approve
Review via email: mp+201567@code.launchpad.net

Commit message

bump debian version for mir to 0.1.4

Description of the change

bump debian version for mir to 0.1.4

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) :
review: Approve
166. By kevin gunn

update use of configure_output signature

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Michael Terry (mterry) wrote :

This now needs to look like:

22 displayConfigOutput.current_mode_index, //unchanged
23 + displayConfigOutput.current_format, //unchanged
24 newPowerMode,
25 + displayConfigOutput.orientation //unchanged
26 );

review: Needs Fixing
Revision history for this message
Gerry Boland (gerboland) wrote :

if you apply this patch to your tree, it should work fine:

=== modified file 'src/unity-mir/dbusscreen.cpp'
--- src/unity-mir/dbusscreen.cpp 2014-01-28 22:59:52 +0000
+++ src/unity-mir/dbusscreen.cpp 2014-01-30 19:14:05 +0000
@@ -73,7 +73,8 @@
                         displayConfigOutput.top_left, //unchanged
                         displayConfigOutput.current_mode_index, //unchanged
                         displayConfigOutput.current_format,
- newPowerMode
+ newPowerMode,
+ displayConfigOutput.orientation //unchanged
                         );
         }
     });

Revision history for this message
Gerry Boland (gerboland) wrote :

hmm, whitespace messed up :(

Revision history for this message
kevin gunn (kgunn72) wrote :

not quite, unfortunately mir 0.1.4 is an equivalent snapshot of of the mir dev-branch at r1330
so the displayConfigOutput.orientation will come only in 0.1.5

Revision history for this message
Gerry Boland (gerboland) wrote :

> not quite, unfortunately mir 0.1.4 is an equivalent snapshot of of the mir
> dev-branch at r1330
> so the displayConfigOutput.orientation will come only in 0.1.5
Ah ok, sorry about that

167. By kevin gunn

update configure_output with new field

Revision history for this message
kevin gunn (kgunn72) wrote :

actually, since landing pipe is clogged. took the time to update mir 0.1.4 to include the change of displayConfigOutput.orientation //unchanged on the configure_output func call

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-01-16 15:57:33 +0000
3+++ debian/control 2014-02-04 01:57:25 +0000
4@@ -6,8 +6,8 @@
5 cmake,
6 pkg-config,
7 libplatform-api1-dev,
8- libmirserver-dev (>= 0.1.3),
9- libmirclient-dev (>= 0.1.3),
10+ libmirserver-dev (>= 0.1.4),
11+ libmirclient-dev (>= 0.1.4),
12 libunity-api-dev,
13 libupstart-app-launch2-dev,
14 qt5-default,
15
16=== modified file 'src/unity-mir/dbusscreen.cpp'
17--- src/unity-mir/dbusscreen.cpp 2013-11-28 07:48:31 +0000
18+++ src/unity-mir/dbusscreen.cpp 2014-02-04 01:57:25 +0000
19@@ -72,7 +72,9 @@
20 displayConfigOutput.used, //unchanged
21 displayConfigOutput.top_left, //unchanged
22 displayConfigOutput.current_mode_index, //unchanged
23- newPowerMode
24+ displayConfigOutput.current_format,
25+ newPowerMode,
26+ displayConfigOutput.orientation //unchanged
27 );
28 }
29 });

Subscribers

People subscribed via source and target branches