Code review comment for lp:~kfunk/libdbusmenu-qt/libdbusmenu-qt

Revision history for this message
Albert Astals Cid (aacid) wrote :

running dpkg-buildpackage on this branch fails

Linking CXX executable dbusmenuexportertest
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `ManualSignalSpy::ManualSignalSpy()':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:33: undefined reference to `vtable for ManualSignalSpy'
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `MenuFiller::MenuFiller(QMenu*)':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:84: undefined reference to `vtable for MenuFiller'
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `DBusMenuExporterTest::testDynamicSubMenu()':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:79: undefined reference to `vtable for MenuFiller'
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:33: undefined reference to `vtable for ManualSignalSpy'
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `ManualSignalSpy::ManualSignalSpy()':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:33: undefined reference to `vtable for ManualSignalSpy'
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `DBusMenuExporterTest::testActivateAction()':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:33: undefined reference to `vtable for ManualSignalSpy'
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `ManualSignalSpy::ManualSignalSpy()':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:33: undefined reference to `vtable for ManualSignalSpy'
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `DBusMenuExporterTest::testSetStatus()':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:33: undefined reference to `vtable for ManualSignalSpy'
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o:/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:33: more undefined references to `vtable for ManualSignalSpy' follow
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `MenuFiller::~MenuFiller()':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:79: undefined reference to `vtable for MenuFiller'
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `MenuFiller::~MenuFiller()':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/testutils.h:79: undefined reference to `vtable for MenuFiller'
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `DBusMenuExporterTest::DBusMenuExporterTest()':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/dbusmenuexportertest.h:32: undefined reference to `vtable for DBusMenuExporterTest'
CMakeFiles/dbusmenuexportertest.dir/dbusmenuexportertest.cpp.o: In function `DBusMenuExporterTest::~DBusMenuExporterTest()':
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/dbusmenuexportertest.h:32: undefined reference to `vtable for DBusMenuExporterTest'
/home/tsdgeos_work/moo/libdbusmenu-qt/tests/dbusmenuexportertest.h:32: undefined reference to `vtable for DBusMenuExporterTest'
../src/libdbusmenu-qt.so.2.6.0: undefined reference to `DBusMenuExporterDBus::ItemsPropertiesUpdated(QList<DBusMenuItem>, QList<DBusMenuItemKeys>)'
../src/libdbusmenu-qt.so.2.6.0: undefined reference to `DBusMenuExporterDBus::LayoutUpdated(unsigned int, int)'
../src/libdbusmenu-qt.so.2.6.0: undefined reference to `vtable for DBusMenuExporter'
../src/libdbusmenu-qt.so.2.6.0: undefined reference to `DBusMenuExporterDBus::ItemActivationRequested(int, unsigned int)'
../src/libdbusmenu-qt.so.2.6.0: undefined reference to `vtable for DBusMenu'
../src/libdbusmenu-qt.so.2.6.0: undefined reference to `vtable for DBusMenuExporterDBus'
../src/libdbusmenu-qt.so.2.6.0: undefined reference to `DBusMenu::staticMetaObject'
collect2: error: ld returned 1 exit status

review: Needs Fixing

« Back to merge proposal