Launchpad itself

Merge lp:~kfogel/launchpad/cc-script-2010-01-28-updates into lp:launchpad

  1. cc-script-2010-01-28-updates
  2. Merge into devel
Proposed by Karl Fogel on 2010-01-28
Status: Merged
Approved by: Karl Fogel on 2010-01-28
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~kfogel/launchpad/cc-script-2010-01-28-updates
Merge into: lp:launchpad
Diff against target: 41 lines (+5/-1)
1 file modified
utilities/community-contributions.py (+5/-1)
To merge this branch: bzr merge lp:~kfogel/launchpad/cc-script-2010-01-28-updates
Reviewer Review Type Date Requested Status
Cody A.W. Somerville (community) 2010-01-28 Approve on 2010-01-28
Review via email: mp+18183@code.launchpad.net
To post a comment you must log in.
Karl Fogel (kfogel) wrote :

Update the list in utilities/community-contributions.py that tells the script not to count Canonical employees -- even when committing from non-Canonical addresses for historical reasons -- as community contributors. Also, update an "XXX" comment about this.

(Yes, yes, I know, Canonical devs are part of the development community too, but that's not the point of what we're showing on https://dev.launchpad.net/Contributions :-) !)

Cody A.W. Somerville (cody-somerville) :
review: Approve
Tim Penhey (thumper) wrote :

Why not look to see of the person is a member of the canonical team?

Karl Fogel (kfogel) wrote :

Tim, that's what the "XXX" comment is about :-).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'utilities/community-contributions.py'
2--- utilities/community-contributions.py 2010-02-05 19:43:58 +0000
3+++ utilities/community-contributions.py 2010-02-10 14:30:31 +0000
4@@ -60,7 +60,7 @@
5 # counted as a Canonical contributor, sometimes Canonical people
6 # submit from personal addresses, so we still need a list.
7 #
8-# XXX: Karl Fogel 2009-09-10: Really, this ought to use launchpadlib
9+# XXX: Karl Fogel 2009-09-10 bug=513608: We should use launchpadlib
10 # to consult Launchpad itself to find out who's a Canonical developer.
11 known_canonical_devs = (
12 u'Aaron Bentley',
13@@ -93,6 +93,7 @@
14 u'Henning Eggers',
15 u'Herb McNew',
16 u'James Henstridge',
17+ u'Jelmer Vernooij',
18 u'Jeroen Vermeulen',
19 u'Jonathan Knowles',
20 u'Jonathan Lange',
21@@ -101,10 +102,12 @@
22 u'Kees Cook',
23 u'Launch Pad',
24 u'Launchpad Developers',
25+ u'LaMont Jones',
26 u'Leonard Richardson',
27 u'Malcolm Cleaton',
28 u'Maris Fogels',
29 u'Martin Albisetti',
30+ u'Martin Pool',
31 u'Matt Zimmerman',
32 u'Matthew Revell',
33 u'Michael Hudson',
34@@ -115,6 +118,7 @@
35 u'Robert Collins',
36 u'Sidnei',
37 u'Sidnei da Silva',
38+ u'Steve Kowalik',
39 u'Steve McInerney',
40 u'Stuart Bishop',
41 u'Tom Berger',