Merge lp:~kfogel/launchpad/582977-api-in-robots.txt into lp:launchpad

Proposed by Karl Fogel
Status: Merged
Merged at revision: 10921
Proposed branch: lp:~kfogel/launchpad/582977-api-in-robots.txt
Merge into: lp:launchpad
Diff against target: 10 lines (+1/-1)
1 file modified
lib/canonical/launchpad/templates/robotstxt.pt (+1/-1)
To merge this branch: bzr merge lp:~kfogel/launchpad/582977-api-in-robots.txt
Reviewer Review Type Date Requested Status
Francis J. Lacoste (community) code release-critical Approve
Review via email: mp+25633@code.launchpad.net

Description of the change

Disallow access under /api/ in robots.txt.

(Is there anything more we'd need to do -- i.e., does lib/canonical/launchpad/templates/robotstxt.pt get automatically propagated out to /robots.txt on the production servers?)

To post a comment you must log in.
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

I have no idea if the deployment of robots.txt is automatic to production. Maybe that file is only used for the local instance.

Better to ask a LOSA for confirmation. If that file is automatically deployed, we should cherry-pick this.

review: Approve (code release-critical)
Revision history for this message
Karl Fogel (kfogel) wrote :

Asking them now.

Revision history for this message
Karl Fogel (kfogel) wrote :

Okay, it turns out that filing an RT is the way to go. And we should probably remove that template, or at least add a comment noting that it is not used in production. I'll make a separate MP about that.

Revision history for this message
Karl Fogel (kfogel) wrote :

Sorry, meant to mention: RT 39388.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/canonical/launchpad/templates/robotstxt.pt'
2--- lib/canonical/launchpad/templates/robotstxt.pt 2009-07-17 17:59:07 +0000
3+++ lib/canonical/launchpad/templates/robotstxt.pt 2010-05-25 17:02:29 +0000
4@@ -6,6 +6,6 @@
5 <tal:dummy define="dummy python:request.response.setHeader('content-type',
6 'text/plain')" />
7 User-agent: *
8-Disallow:
9+Disallow: /api/
10 </tal:root>
11