lp:~kevang/mnemosyne-proj/grade-shortcuts-improvements
- Get this branch:
- bzr branch lp:~kevang/mnemosyne-proj/grade-shortcuts-improvements
Branch merges
- Peter Bienstman: Approve
-
Diff: 99 lines (+11/-25)2 files modifiedmnemosyne/mnemosyne/pyqt_ui/review_wdgt.py (+11/-7)
mnemosyne/mnemosyne/pyqt_ui/review_wdgt.ui (+0/-18)
Branch information
Recent revisions
- 1864. By Kilian Evang <email address hidden>
-
ReviewWdgt no longer associates shortcuts with grade buttons, instead handles
all key presses in the keyPressEvent method. I think this allows for a more
unified, less error-prone treatment of the keyboard interface.In addition, it now always avoids reacting to auto-repeated grade key presses.
For example, if you press a number key to show the answer and hold it down for
too long, it would previously immediately grade the card. This is no longer the
case. There was no obvious way to solve this problem with the shortcuts.Furthermore, it now always avoids grading the current card when the answer is
not showing. Previously, there was a race condition that could lead to two
cards being graded in a row when the user accidentally hit two grade keys at
once, see https://code.launchpad .net/~kevang/ mnemosyne- proj/grade_ only_if_ showing/ +merge/ 235605
for a detailed description.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:~peter-bienstman/mnemosyne-proj/trunk