Merge lp:~kenrumer/python-jenkins/build_info into lp:~python-jenkins-developers/python-jenkins/trunk
Proposed by
Ken Rumer
Status: | Merged |
---|---|
Merged at revision: | 13 |
Proposed branch: | lp:~kenrumer/python-jenkins/build_info |
Merge into: | lp:~python-jenkins-developers/python-jenkins/trunk |
Diff against target: |
73 lines (+38/-0) 2 files modified
doc/index.rst (+10/-0) jenkins/__init__.py (+28/-0) |
To merge this branch: | bzr merge lp:~kenrumer/python-jenkins/build_info |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Page | Approve | ||
Review via email: mp+95243@code.launchpad.net |
Commit message
Added build info method
Description of the change
Try this again.
Gets build information from Jenkins. Can use to get the status of a build. Loop until the build is complete, return the artifact URL(s).
Example usage:
import jenkins
import time
j = jenkins.Jenkins('http://
next_
To post a comment you must log in.
Thanks for re-doing this merge proposal Ken.
A few comments:
1) Please could you add documentation to the method in the python code as well as index.rst - helps folk who 'pydoc jenkins'.
2) The string handling for errors is inconsistent with the rest of the package:
Please use:
raise JenkinsExceptio n('job[ %s] number[%d] does not exist'%(name, number))
instead of:
raise JenkinsExceptio n('job[ !s] number[!d] does not exist'.format(name, number))
I appreciate that both produce the same result but I would like to keep the package consistent.
Other than that looks good - I'll merge once you have made the above amendments.
Cheers
James