Unity 8

Merge lp:~ken-vandine/unity8/mouse_touchpad_schema into lp:unity8

  1. mouse_touchpad_schema
  2. Merge into trunk
Proposed by Ken VanDine on 2016-01-05
Status: Rejected
Rejected by: Michael Terry on 2016-01-21
Proposed branch: lp:~ken-vandine/unity8/mouse_touchpad_schema
Merge into: lp:unity8
Diff against target: 95 lines (+79/-0)
1 file modified
data/com.canonical.Unity8.gschema.xml (+79/-0)
To merge this branch: bzr merge lp:~ken-vandine/unity8/mouse_touchpad_schema
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve on 2016-01-13
Michael Zanetti (community) 2016-01-05 Needs Information on 2016-01-07
PS Jenkins bot continuous-integration Needs Fixing on 2016-01-05
Review via email: mp+281643@code.launchpad.net

Commit Message

Added keys needed for mouse and touchpad settings

Description of the Change

Added keys needed for mouse and touchpad settings

To post a comment you must log in.
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1906
http://jenkins.qa.ubuntu.com/job/unity8-ci/7017/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/5934/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/432/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1722
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/425
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1617
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1617
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/424
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/423
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4582/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5945
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/5945/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26427
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/186/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/430
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/430/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/26426

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7017/rebuild

review: Needs Fixing (continuous-integration)
Michael Zanetti (mzanetti) wrote :

Is there a reason why we're not reusing the existing ones from unity7?

review: Needs Information
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:1906
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/19/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/19/rebuild

review: Approve (continuous-integration)
Michael Terry (mterry) wrote :

This also seems like not a great place for these settings. Are they really unity8 specific? They seem system-wide. Why'd you take these out of your other branch, out of the system-settings schema?

Ken VanDine (ken-vandine) wrote :

> This also seems like not a great place for these settings. Are they really
> unity8 specific? They seem system-wide. Why'd you take these out of your
> other branch, out of the system-settings schema?

I only had them in system-settings to help test the UI, they really don't belong in system-settings either. Settings will only be changing them, not using them. I'd be fine with moving them to a more generic package where the shell can use them.

Most of the settings for this that were in the design didn't really match up with unity7/gnome settings (not sure why). I'd be happy to rework that if you have suggestions.

Michael Terry (mterry) wrote :

The "package-neutral" location we have for gsettings and AccountsService schemas is lp:gsettings-ubuntu-touch-schemas. I can propose a branch there.

Michael Terry (mterry) wrote :

Unmerged revisions

1906. By Ken VanDine on 2016-01-05

merged trunk

1905. By Ken VanDine on 2015-10-19

merged trunk

1904. By Ken VanDine on 2015-08-11

Fixed types

1903. By Ken VanDine on 2015-08-06

Fixed primary-button-enum in schema

1902. By Ken VanDine on 2015-08-06

Added keys needed for mouse and touchpad settings

1901. By Launchpad Translations on behalf of unity-team on 2015-08-05

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/com.canonical.Unity8.gschema.xml'
2--- data/com.canonical.Unity8.gschema.xml 2015-11-24 17:44:18 +0000
3+++ data/com.canonical.Unity8.gschema.xml 2016-01-05 14:56:28 +0000
4@@ -5,12 +5,91 @@
5 <value nick="Automatic" value="2" />
6 </enum>
7
8+ <enum id="primary-button-enum">
9+ <value nick="Left" value="0" />
10+ <value nick="Middle" value="1" />
11+ <value nick="Right" value="2" />
12+ </enum>
13+
14 <schema path="/com/canonical/unity8/" id="com.canonical.Unity8" gettext-domain="unity8">
15 <key enum="usage-mode-enum" name="usage-mode">
16 <default>"Automatic"</default>
17 <summary>The usage mode.</summary>
18 <description>The usage mode chosen will affect the Window Management behaviour.</description>
19 </key>
20+
21+ <key enum="primary-button-enum" name="mouse-primary-button">
22+ <default>"Left"</default>
23+ <summary>Primary Mouse Button.</summary>
24+ <description>The primary mouse button.</description>
25+ </key>
26+
27+ <key name="mouse-cursor-speed" type="d">
28+ <default>0.5</default>
29+ <summary>Mouse cursor speed.</summary>
30+ <description>Mouse cursor speed.</description>
31+ </key>
32+
33+ <key name="mouse-double-click-speed" type="i">
34+ <default>100</default>
35+ <summary>Mouse double click speed.</summary>
36+ <description>Mouse double click speed in milliseconds.</description>
37+ </key>
38+
39+ <key name="mouse-scroll-speed" type="d">
40+ <default>0.5</default>
41+ <summary>Mouse scroll speed.</summary>
42+ <description>Mouse scroll speed.</description>
43+ </key>
44+
45+ <key enum="primary-button-enum" name="touchpad-primary-button">
46+ <default>"Left"</default>
47+ <summary>Primary Touchpad Button.</summary>
48+ <description>The primary touchpad button.</description>
49+ </key>
50+
51+ <key name="touchpad-cursor-speed" type="d">
52+ <default>0.5</default>
53+ <summary>Touchpad cursor speed.</summary>
54+ <description>Touchpad cursor speed.</description>
55+ </key>
56+
57+ <key name="touchpad-double-click-speed" type="i">
58+ <default>100</default>
59+ <summary>Touchpad double click speed.</summary>
60+ <description>Touchpad double click speed in milliseconds.</description>
61+ </key>
62+
63+ <key name="touchpad-scroll-speed" type="d">
64+ <default>0.5</default>
65+ <summary>Touchpad scroll speed.</summary>
66+ <description>Touchpad scroll speed.</description>
67+ </key>
68+
69+ <key name="touchpad-disable-while-typing" type="b">
70+ <default>false</default>
71+ <summary>Ignore Touchpad while typing.</summary>
72+ <description>Disable touchpad while typing.</description>
73+ </key>
74+
75+ <key name="touchpad-tap-to-click" type="b">
76+ <default>false</default>
77+ <summary>Tap to click.</summary>
78+ <description>Touchpad tap to click.</description>
79+ </key>
80+
81+ <key name="touchpad-two-finger-scroll" type="b">
82+ <default>false</default>
83+ <summary>Two finger scrolling.</summary>
84+ <description>Touchpad two finger scrolling.</description>
85+ </key>
86+
87+ <key name="touchpad-disable-with-mouse" type="b">
88+ <default>true</default>
89+ <summary>Ignore touchpad when a mouse is connected.</summary>
90+ <description>Disable touchpad when a mouse is connected.</description>
91+ </key>
92+
93 <key type="y" name="edge-barrier-sensitivity">
94 <default>35</default>
95 <range min="1" max="100"/>

Subscribers

People subscribed via source and target branches