Merge lp:~ken-vandine/unity-lens-friends/ftbfs_intltool into lp:unity-lens-friends

Proposed by Ken VanDine
Status: Merged
Approved by: Robert Bruce Park
Approved revision: 70
Merged at revision: 71
Proposed branch: lp:~ken-vandine/unity-lens-friends/ftbfs_intltool
Merge into: lp:unity-lens-friends
Diff against target: 105 lines (+40/-9)
5 files modified
Makefile.am (+2/-0)
autogen.sh (+33/-5)
configure.ac (+3/-4)
debian/control (+1/-0)
debian/rules (+1/-0)
To merge this branch: bzr merge lp:~ken-vandine/unity-lens-friends/ftbfs_intltool
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Robert Bruce Park Approve
Review via email: mp+193633@code.launchpad.net

Commit message

Fixed FTBFS with gnome-common 3.10, you can't use both IT_PROG_INTLTOOL and
AM_GNU_GETTEXT. Also cleaned up some automake depreciations.

Specify intltool version dependency in debian/control.

Description of the change

Fixed FTBFS with gnome-common 3.10, you can't use both IT_PROG_INTLTOOL and
AM_GNU_GETTEXT. Also cleaned up some automake depreciations.

Specify intltool version dependency in debian/control.

To post a comment you must log in.
Revision history for this message
Robert Bruce Park (robru) wrote :

lgtm, just waiting for jenkins.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile.am'
2--- Makefile.am 2012-10-17 20:13:50 +0000
3+++ Makefile.am 2013-11-01 17:02:18 +0000
4@@ -1,1 +1,3 @@
5+ACLOCAL_AMFLAGS = -I m4
6+
7 SUBDIRS = src data po
8
9=== modified file 'autogen.sh'
10--- autogen.sh 2012-10-16 04:41:52 +0000
11+++ autogen.sh 2013-11-01 17:02:18 +0000
12@@ -1,11 +1,39 @@
13 #!/bin/sh
14+# Run this to generate all the initial makefiles, etc.
15+
16+srcdir=`dirname $0`
17+test -z "$srcdir" && srcdir=.
18
19 PKG_NAME="unity-lens-friends"
20
21-which gnome-autogen.sh || {
22- echo "You need gnome-common from GNOME SVN"
23- exit 1
24+(test -f $srcdir/configure.ac \
25+ && test -f $srcdir/autogen.sh) || {
26+ echo -n "**Error**: Directory \`$srcdir' does not look like the"
27+ echo " top-level $PKG_NAME directory"
28+ exit 1
29 }
30
31-USE_GNOME2_MACROS=1 \
32-. gnome-autogen.sh
33+if which gnome-autogen.sh ; then
34+ REQUIRED_AUTOMAKE_VERSION=1.9 . gnome-autogen.sh
35+else
36+ if which intltoolize && which gtkdocize && which autoreconf ; then
37+ intltoolize --copy --force --automake || \
38+ (echo "There was an error in running intltoolize." > /dev/stderr;
39+ exit 1)
40+ autoreconf --force --install || \
41+ (echo "There was an error in running autoreconf." > /dev/stderr;
42+ exit 1)
43+ else
44+ echo "No build script available. You have two choices:"
45+ echo "1. You need to install the gnome-common module and make"
46+ echo " sure the gnome-autogen.sh script is in your \$PATH."
47+ echo "2. You need to install the following scripts:"
48+ echo " * intltool"
49+ echo " * libtool"
50+ echo " * automake"
51+ echo " * autoconf"
52+ echo " Additionally, you need to make"
53+ echo " sure that they are in your \$PATH."
54+ exit 1
55+ fi
56+fi
57
58=== modified file 'configure.ac'
59--- configure.ac 2013-07-25 03:01:50 +0000
60+++ configure.ac 2013-11-01 17:02:18 +0000
61@@ -1,8 +1,10 @@
62+AC_PREREQ(2.65)
63 AC_INIT([unity-lens-friends], 0.1)
64 AM_INIT_AUTOMAKE
65 AC_CONFIG_HEADERS([config.h])
66
67 LT_INIT
68+AC_CONFIG_MACRO_DIR([m4])
69
70 AM_PROG_VALAC([0.17])
71 AC_PROG_CC
72@@ -16,10 +18,7 @@
73 AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE, "$GETTEXT_PACKAGE", [Name of the default get text domain])
74 localedir='$(prefix)/$(DATADIRNAME)/locale'
75 AC_SUBST(localedir)
76-AM_GNU_GETTEXT([external])
77-AM_GNU_GETTEXT_VERSION([0.17])
78-IT_PROG_INTLTOOL([0.40])
79-
80+IT_PROG_INTLTOOL(0.50.0)
81
82 AC_DEFINE_UNQUOTED(LOCALE_DIR, "${PREFIX}/${DATADIRNAME}/locale",[Locale directory])
83 AC_DEFINE_UNQUOTED(PKGDATADIR, "${PREFIX}/${DATADIRNAME}/${PACKAGE}", [Package data directory])
84
85=== modified file 'debian/control'
86--- debian/control 2013-07-11 16:59:44 +0000
87+++ debian/control 2013-11-01 17:02:18 +0000
88@@ -7,6 +7,7 @@
89 dh-autoreconf,
90 dh-translations,
91 gnome-common,
92+ intltool (>= 0.50.0),
93 libaccounts-glib-dev,
94 libdee-dev (>= 1.0.0),
95 libgee-dev,
96
97=== modified file 'debian/rules'
98--- debian/rules 2013-08-02 12:05:43 +0000
99+++ debian/rules 2013-11-01 17:02:18 +0000
100@@ -10,4 +10,5 @@
101 NOCONFIGURE=1 dh_autoreconf ./autogen.sh
102
103 override_dh_install:
104+ rm -f debian/*/usr/lib/*/unity/*.la
105 dh_install --fail-missing -X.la

Subscribers

People subscribed via source and target branches

to all changes: