Unity Asset Pool

Merge lp:~ken-vandine/unity-asset-pool/0.8.24daily13.03.20.1-0ubuntu2 into lp:unity-asset-pool

  1. 0.8.24daily13.03.20.1-0ubuntu2
  2. Merge into trunk
Proposed by Ken VanDine
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp:~ken-vandine/unity-asset-pool/0.8.24daily13.03.20.1-0ubuntu2
Merge into: lp:unity-asset-pool
Diff against target: 35 lines (+8/-9)
2 files modified
debian/changelog (+8/-0)
debian/control (+0/-9)
To merge this branch: bzr merge lp:~ken-vandine/unity-asset-pool/0.8.24daily13.03.20.1-0ubuntu2
Reviewer Review Type Date Requested Status
Sebastien Bacher Disapprove
Review via email: mp+154495@code.launchpad.net

Commit message

* debian/control
    - Don't use a replaces, only breaks for the account-plugin-*
      packages (LP: #1157747)

Description of the change

- Don't use a replaces, only breaks for the account-plugin-* packages (LP: #1157747)

To post a comment you must log in.
lp:~ken-vandine/unity-asset-pool/0.8.24daily13.03.20.1-0ubuntu2 updated
74. By Ken VanDine

fixed changelog

Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks Ken but that's wrong, "Replaces:" is used for "can overwrite packages that were shipped in" and that's the right thing to do here

review: Disapprove

Unmerged revisions

74. By Ken VanDine

fixed changelog

73. By Ken VanDine

* debian/control
  - Don't use a breaks, only replaces for the account-plugin-*
    packages (LP: #1157747)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-03-20 15:25:21 +0000
3+++ debian/changelog 2013-03-20 19:49:22 +0000
4@@ -1,3 +1,11 @@
5+unity-asset-pool (0.8.24daily13.03.20.1-0ubuntu2) raring; urgency=low
6+
7+ * debian/control
8+ - Don't use a replaces, only breaks for the account-plugin-*
9+ packages (LP: #1157747)
10+
11+ -- Ken VanDine <ken.vandine@canonical.com> Wed, 20 Mar 2013 15:24:54 -0400
12+
13 unity-asset-pool (0.8.24daily13.03.20.1-0ubuntu1) raring; urgency=low
14
15 [ Ken VanDine ]
16
17=== modified file 'debian/control'
18--- debian/control 2013-03-20 14:58:00 +0000
19+++ debian/control 2013-03-20 19:49:22 +0000
20@@ -18,15 +18,6 @@
21 hicolor-icon-theme
22 Provides: unity-icon-theme
23 Replaces: account-plugin-icons (<= 0.10bzr13.02.27-0ubuntu1),
24- account-plugin-google (<= 0.10bzr13.02.27-0ubuntu1),
25- account-plugin-facebook (<= 0.10bzr13.02.27-0ubuntu1),
26- account-plugin-twitter (<= 0.10bzr13.02.27-0ubuntu1),
27- account-plugin-flickr (<= 0.10bzr13.02.27-0ubuntu1),
28- account-plugin-identica (<= 0.10bzr13.02.27-0ubuntu1),
29- account-plugin-foursquare (<= 0.10bzr13.02.27-0ubuntu1),
30- account-plugin-windows-live (<= 0.10bzr13.02.27-0ubuntu1),
31- account-plugin-sohu (<= 0.10bzr13.02.27-0ubuntu1),
32- account-plugin-sina (<= 0.10bzr13.02.27-0ubuntu1),
33 unity-webapps-common (<= 2.4.13-0ubuntu1)
34 Breaks: account-plugin-icons (<= 0.10bzr13.02.27-0ubuntu1),
35 account-plugin-google (<= 0.10bzr13.02.27-0ubuntu1),

Subscribers

People subscribed via source and target branches

to all changes: