Merge lp:~ken-vandine/ubuntu-system-settings/urfkill_suggests into lp:ubuntu-system-settings

Proposed by Ken VanDine
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 1721
Merged at revision: 1724
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/urfkill_suggests
Merge into: lp:ubuntu-system-settings
Diff against target: 30 lines (+2/-1)
2 files modified
debian/control (+1/-1)
plugins/flight-mode/flight-mode.settings (+1/-0)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/urfkill_suggests
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
system-apps-ci-bot continuous-integration Needs Fixing
Review via email: mp+306236@code.launchpad.net

Commit message

Make urfkill a suggests and only show the flight-mode plugin if urfkill is installed.

Description of the change

Make urfkill a suggests and only show the flight-mode plugin if urfkill is installed.

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1721
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/157/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1575/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1575
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1423
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1423/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1423
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1423/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1423
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=yakkety/1423/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1423
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1423/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1423
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1423/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1423
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=yakkety/1423/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/1423/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/1423/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=yakkety/1423/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-system-settings-ci/157/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM!

review: Approve
1722. By Ken VanDine

merged trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2016-09-16 15:13:17 +0000
3+++ debian/control 2016-09-27 13:30:30 +0000
4@@ -103,7 +103,6 @@
5 libsystemsettings1 (= ${binary:Version}),
6 ubuntu-keyboard-data (>= 0.99.trunk.phablet2+15.04.20150421),
7 ubuntu-wallpapers,
8- urfkill,
9 # for the session-migration script (python3 itself also for the push helper)
10 python3,
11 python3-gi,
12@@ -113,6 +112,7 @@
13 qml-module-ubuntu-connectivity (>= 0.7.1)
14 Suggests: system-image-dbus (>= 3.1),
15 aethercast,
16+ urfkill,
17 Recommends: ubuntu-system-settings-online-accounts,
18 ubuntu-touch-sounds,
19 Conflicts: ubuntu-system-settings-example
20
21=== modified file 'plugins/flight-mode/flight-mode.settings'
22--- plugins/flight-mode/flight-mode.settings 2015-11-23 14:38:43 +0000
23+++ plugins/flight-mode/flight-mode.settings 2016-09-27 13:30:30 +0000
24@@ -13,5 +13,6 @@
25 ],
26 "has-dynamic-keywords": false,
27 "has-dynamic-visibility": false,
28+ "visible-if-file-exists": "/etc/dbus-1/system.d/org.freedesktop.URfkill.conf",
29 "entry-component": "EntryComponent.qml"
30 }

Subscribers

People subscribed via source and target branches