Merge lp:~ken-vandine/ubuntu-system-settings/storage_page_speedup into lp:ubuntu-system-settings
Proposed by
Ken VanDine
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jonas G. Drange | ||||
Approved revision: | 1637 | ||||
Merged at revision: | 1632 | ||||
Proposed branch: | lp:~ken-vandine/ubuntu-system-settings/storage_page_speedup | ||||
Merge into: | lp:ubuntu-system-settings | ||||
Diff against target: |
323 lines (+160/-108) 3 files modified
plugins/about/Storage.qml (+119/-92) plugins/about/storageabout.cpp (+36/-13) plugins/about/storageabout.h (+5/-3) |
||||
To merge this branch: | bzr merge lp:~ken-vandine/ubuntu-system-settings/storage_page_speedup | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonas G. Drange (community) | Approve | ||
Review via email: mp+290159@code.launchpad.net |
Commit message
* Use a loader for the Storage page and show an ActivityIndicator until the page is ready
* Improved performance of building the list of mountedVolumes
Description of the change
* Use a loader for the Storage page and show an ActivityIndicator until the page is ready
* Improved performance of building the list of mountedVolumes
To post a comment you must log in.
Added a couple of comments. Also, you're basically solving bug 1488005 for the storage panel only. Should we consider solving it for all pages on the pageStack?