Merge lp:~ken-vandine/ubuntu-system-settings/rtm-lp1392051 into lp:ubuntu-system-settings/rtm-14.09

Proposed by Ken VanDine
Status: Merged
Approved by: Ken VanDine
Approved revision: 948
Merged at revision: 952
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/rtm-lp1392051
Merge into: lp:ubuntu-system-settings/rtm-14.09
Diff against target: 32 lines (+4/-0)
2 files modified
plugins/system-update/update_manager.cpp (+3/-0)
plugins/system-update/update_manager.h (+1/-0)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/rtm-lp1392051
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu Touch System Settings Pending
Review via email: mp+244294@code.launchpad.net

Commit message

[system-update] remember the latest SystemUpdate downloaded and compare
the version when checking again and set updateReady appropriately. This
fixes the handling of downloaded updates when auto-download is false.

Description of the change

[system-update] remember the latest SystemUpdate downloaded and compare
the version when checking again and set updateReady appropriately. This
fixes the handling of downloaded updates when auto-download is false.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
947. By Ken VanDine

merged rtm-14.09

948. By Ken VanDine

Set m_latestDownload after download is complete

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/system-update/update_manager.cpp'
2--- plugins/system-update/update_manager.cpp 2014-10-27 13:17:32 +0000
3+++ plugins/system-update/update_manager.cpp 2014-12-16 15:39:06 +0000
4@@ -236,6 +236,8 @@
5 m_model.insert(0, QVariant::fromValue(update));
6 Q_EMIT modelChanged();
7 Q_EMIT updateAvailableFound(update->updateState());
8+ if (update->getRemoteVersion() == m_latestDownload)
9+ updateDownloaded();
10 }
11 m_systemCheckingUpdate = false;
12
13@@ -250,6 +252,7 @@
14 update->setSelected(false);
15 update->setUpdateState(false);
16 update->setUpdateReady(true);
17+ m_latestDownload = update->getRemoteVersion();
18 Q_EMIT systemUpdateDownloaded();
19 }
20 }
21
22=== modified file 'plugins/system-update/update_manager.h'
23--- plugins/system-update/update_manager.h 2014-10-24 20:06:13 +0000
24+++ plugins/system-update/update_manager.h 2014-12-16 15:39:06 +0000
25@@ -141,6 +141,7 @@
26 int m_downloadMode;
27 QVariantList m_model;
28 Token m_token;
29+ QString m_latestDownload;
30
31 #ifdef TESTS
32 FakeNetwork m_network;

Subscribers

People subscribed via source and target branches