Merge lp:~ken-vandine/ubuntu-system-settings/rtm-brightness_crash into lp:ubuntu-system-settings/rtm-14.09

Proposed by Ken VanDine
Status: Merged
Approved by: Ken VanDine
Approved revision: 942
Merged at revision: 971
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/rtm-brightness_crash
Merge into: lp:ubuntu-system-settings/rtm-14.09
Diff against target: 30 lines (+7/-2)
1 file modified
plugins/brightness/brightness.cpp (+7/-2)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/rtm-brightness_crash
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+244202@code.launchpad.net

Commit message

[brightness] ensure properties are not use undefined

Description of the change

[brightness] ensure properties are not use undefined

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/brightness/brightness.cpp'
2--- plugins/brightness/brightness.cpp 2014-07-23 13:44:31 +0000
3+++ plugins/brightness/brightness.cpp 2014-12-09 18:58:59 +0000
4@@ -23,6 +23,7 @@
5 #include <QDBusArgument>
6 #include <QDBusReply>
7 #include <QDBusMetaType>
8+#include <QDebug>
9
10 // Returned data from getBrightnessParams
11 struct BrightnessParams {
12@@ -58,13 +59,17 @@
13 m_powerdIface ("com.canonical.powerd",
14 "/com/canonical/powerd",
15 "com.canonical.powerd",
16- m_systemBusConnection)
17+ m_systemBusConnection),
18+ m_powerdRunning(false),
19+ m_autoBrightnessAvailable(false)
20 {
21 qRegisterMetaType<BrightnessParams>();
22 m_powerdRunning = m_powerdIface.isValid();
23
24- if (!m_powerdRunning)
25+ if (!m_powerdRunning) {
26+ qWarning() << m_powerdIface.interface() << m_powerdIface.lastError().message();
27 return;
28+ }
29
30 QDBusMessage reply(m_powerdIface.call("getBrightnessParams"));
31

Subscribers

People subscribed via source and target branches