Merge lp:~ken-vandine/ubuntu-system-settings/rtm-about-multiline-fixes-1390148 into lp:ubuntu-system-settings/rtm-14.09

Proposed by Ken VanDine
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 940
Merged at revision: 955
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/rtm-about-multiline-fixes-1390148
Merge into: lp:ubuntu-system-settings/rtm-14.09
Diff against target: 28 lines (+3/-3)
1 file modified
plugins/about/Version.qml (+3/-3)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/rtm-about-multiline-fixes-1390148
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
Review via email: mp+242100@code.launchpad.net

Commit message

[about] use SingleValueStacked for all information bits in the version panel

Description of the change

[about] use SingleValueStacked for all information bits in the version panel

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks fine to me!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/about/Version.qml'
2--- plugins/about/Version.qml 2014-09-10 19:46:02 +0000
3+++ plugins/about/Version.qml 2014-11-18 17:59:00 +0000
4@@ -56,13 +56,13 @@
5 right: parent.right
6 }
7
8- ListItem.SingleValue {
9+ SingleValueStacked {
10 objectName: "versionBuildNumberItem"
11 text: i18n.tr("OS build number")
12 value: UpdateManager.currentBuildNumber ? UpdateManager.currentBuildNumber : "Non system image"
13 }
14
15- ListItem.SingleValue {
16+ SingleValueStacked {
17 objectName: "ubuntuVersionBuildNumberItem"
18 text: i18n.tr("Ubuntu Image part")
19 value: UpdateManager.currentUbuntuBuildNumber
20@@ -90,7 +90,7 @@
21 visible: storedInfo.deviceBuildDisplayID
22 }
23
24- ListItem.SingleValue {
25+ SingleValueStacked {
26 objectName: "customizationBuildNumberItem"
27 text: i18n.tr("Customization Image part")
28 value: storedInfo.customizationBuildID

Subscribers

People subscribed via source and target branches