Merge lp:~ken-vandine/ubuntu-system-settings/rtm-1390557 into lp:ubuntu-system-settings/rtm-14.09

Proposed by Ken VanDine
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/rtm-1390557
Merge into: lp:ubuntu-system-settings/rtm-14.09
Diff against target: 41 lines (+14/-2)
2 files modified
wizard/qml/Pages/passwd-confirm.qml (+7/-1)
wizard/qml/Pages/passwd-set.qml (+7/-1)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/rtm-1390557
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Jonas G. Drange (community) Approve
Review via email: mp+242121@code.launchpad.net

Commit message

Delay password set/confirm screens after entering the 4th digit

Description of the change

Delay password set/confirm screens after entering the 4th digit

To post a comment you must log in.
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

WFM (krillin)

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

seems like we are not doing more rtm landing, so cleaning the list a bit, that one is rather going to be including with the vivid rebase

Unmerged revisions

940. By Ken VanDine

Delay password set/confirm screens after entering the 4th digit

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'wizard/qml/Pages/passwd-confirm.qml'
2--- wizard/qml/Pages/passwd-confirm.qml 2014-10-31 14:14:22 +0000
3+++ wizard/qml/Pages/passwd-confirm.qml 2014-11-18 19:52:45 +0000
4@@ -60,11 +60,17 @@
5
6 onEntered: {
7 if (passphrase === root.password) {
8- pageStack.next()
9+ confirmTimer.start()
10 } else {
11 clear(true)
12 }
13 }
14+
15+ Timer {
16+ id: confirmTimer
17+ interval: UbuntuAnimation.SnapDuration
18+ onTriggered: pageStack.next()
19+ }
20 }
21
22 Component {
23
24=== modified file 'wizard/qml/Pages/passwd-set.qml'
25--- wizard/qml/Pages/passwd-set.qml 2014-11-03 19:44:49 +0000
26+++ wizard/qml/Pages/passwd-set.qml 2014-11-18 19:52:45 +0000
27@@ -36,7 +36,13 @@
28
29 function confirm() {
30 root.password = lockscreen.passphrase;
31- pageStack.load(Qt.resolvedUrl("passwd-confirm.qml"));
32+ confirmTimer.start()
33+ }
34+
35+ Timer {
36+ id: confirmTimer
37+ interval: UbuntuAnimation.SnapDuration
38+ onTriggered: pageStack.load(Qt.resolvedUrl("passwd-confirm.qml"));
39 }
40
41 UnityComponents.Lockscreen {

Subscribers

People subscribed via source and target branches