Merge lp:~ken-vandine/ubuntu-system-settings/rtm-1382767 into lp:ubuntu-system-settings/rtm-14.09

Proposed by Ken VanDine
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 940
Merged at revision: 968
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/rtm-1382767
Merge into: lp:ubuntu-system-settings/rtm-14.09
Diff against target: 40 lines (+11/-2)
2 files modified
plugins/bluetooth/PageComponent.qml (+9/-2)
plugins/bluetooth/devicemodel.cpp (+2/-0)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/rtm-1382767
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Sebastien Bacher (community) Approve
Review via email: mp+242116@code.launchpad.net

Commit message

[bluetooth] Show bluetooth address instead of name while it's not detected; to be updated once available.

Description of the change

[bluetooth] Show bluetooth address instead of name while it's not detected; to be updated once available.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/bluetooth/PageComponent.qml'
2--- plugins/bluetooth/PageComponent.qml 2014-11-12 16:28:12 +0000
3+++ plugins/bluetooth/PageComponent.qml 2014-11-18 19:38:22 +0000
4@@ -317,7 +317,11 @@
5
6 Page {
7 id: connectedDevicePage
8- title: backend.selectedDevice ? backend.selectedDevice.name : i18n.tr("None")
9+ title: backend.selectedDevice ?
10+ backend.selectedDevice.name.length > 0 ?
11+ backend.selectedDevice.name :
12+ backend.selectedDevice.address
13+ : i18n.tr("None")
14 visible: false
15
16 Flickable {
17@@ -338,7 +342,10 @@
18
19 ListItem.SingleValue {
20 text: i18n.tr("Name")
21- value: backend.selectedDevice ? backend.selectedDevice.name : i18n.tr("None")
22+ value: backend.selectedDevice &&
23+ backend.selectedDevice.name.length > 0 ?
24+ backend.selectedDevice.name :
25+ i18n.tr("None")
26 }
27 ListItem.Standard {
28 Rectangle {
29
30=== modified file 'plugins/bluetooth/devicemodel.cpp'
31--- plugins/bluetooth/devicemodel.cpp 2014-09-16 19:41:44 +0000
32+++ plugins/bluetooth/devicemodel.cpp 2014-11-18 19:38:22 +0000
33@@ -382,6 +382,8 @@
34 if (device->isValid()) {
35 addDevice(device);
36 }
37+ } else {
38+ device->setProperties(properties);
39 }
40 }
41

Subscribers

People subscribed via source and target branches