ubuntu-system-settings

Merge lp:~ken-vandine/ubuntu-system-settings/rtm-1377286 into lp:ubuntu-system-settings/rtm-14.09

  1. rtm-1377286
  2. Merge into rtm-14.09
Proposed by Ken VanDine
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/rtm-1377286
Merge into: lp:ubuntu-system-settings/rtm-14.09
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/notifications/PageComponent.qml (+1/-1)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/rtm-1377286
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Sebastien Bacher (community) Approve
Review via email: mp+242115@code.launchpad.net

Commit message

[notifications] update strings to match the design

Description of the change

[notifications] update strings to match the design

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks, as discussed in previous mps, changing a string invalidate the UI translations the new langpack update, do we have a plan to handle that, or do we consider it fine for e.g spanish customers to have their phone UI regress to english after an ota update?

review: Needs Information
Revision history for this message
Sebastien Bacher (seb128) wrote :

Setting as comment approved, but we need to organize the landing with a langpack update to not regress on translations

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:940
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-rtm-14.09-ci/14/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-rtm-14.09-14.09-armhf-ci/15
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-rtm-14.09-14.09-armhf-ci/15/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-rtm-14.09-ci/14/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

seems like we are not doing more rtm landing, so cleaning the list a bit, that one is rather going to be including with the vivid rebase

Unmerged revisions

940. By Ken VanDine

[notifications] update strings to match the design

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/notifications/PageComponent.qml'
2--- plugins/notifications/PageComponent.qml 2014-11-12 16:03:25 +0000
3+++ plugins/notifications/PageComponent.qml 2014-11-18 19:35:59 +0000
4@@ -37,7 +37,7 @@
5 height: labelSubtitle.height + units.gu(2)
6 Label {
7 id: labelSubtitle
8- text: i18n.tr("Selected apps can alert you using notification bubbles, sounds, vibrations, and the Notification Center.")
9+ text: i18n.tr("Selected apps can alert you using notification bubbles, sounds, vibrations, and the Notifications list.")
10 wrapMode: Text.WordWrap
11 anchors {
12 top: parent.top

Subscribers

People subscribed via source and target branches