Merge lp:~ken-vandine/ubuntu-system-settings/mouse_no_dynamic_vis into lp:ubuntu-system-settings

Proposed by Ken VanDine on 2016-01-27
Status: Merged
Approved by: Ken VanDine on 2016-03-25
Approved revision: 1588
Merged at revision: 1630
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/mouse_no_dynamic_vis
Merge into: lp:ubuntu-system-settings
Prerequisite: lp:~ken-vandine/ubuntu-system-settings/mouse_xvfb_fix
Diff against target: 136 lines (+0/-113)
4 files modified
plugins/mouse/CMakeLists.txt (+0/-2)
plugins/mouse/plugin/CMakeLists.txt (+0/-8)
plugins/mouse/plugin/mouse-plugin.cpp (+0/-65)
plugins/mouse/plugin/mouse-plugin.h (+0/-38)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/mouse_no_dynamic_vis
Reviewer Review Type Date Requested Status
Michael Sheldon (community) Approve on 2016-03-25
PS Jenkins bot continuous-integration Needs Fixing on 2016-01-27
Ubuntu Touch System Settings 2016-01-27 Pending
Review via email: mp+284161@code.launchpad.net

Commit Message

Removed unnecessary mouse-plugin, it was intended for use with dynamic visibility, which is no longer needed.

Description of the Change

Removed unnecessary mouse-plugin, it was intended for use with dynamic visibility, which is no longer needed.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/mouse/CMakeLists.txt'
2--- plugins/mouse/CMakeLists.txt 2016-03-07 16:29:15 +0000
3+++ plugins/mouse/CMakeLists.txt 2016-03-23 15:05:32 +0000
4@@ -1,5 +1,3 @@
5-add_subdirectory(plugin)
6-
7 set(QML_SOURCES
8 PageComponent.qml
9 None.qml
10
11=== removed directory 'plugins/mouse/plugin'
12=== removed file 'plugins/mouse/plugin/CMakeLists.txt'
13--- plugins/mouse/plugin/CMakeLists.txt 2015-07-30 18:51:21 +0000
14+++ plugins/mouse/plugin/CMakeLists.txt 1970-01-01 00:00:00 +0000
15@@ -1,8 +0,0 @@
16-include_directories(${CMAKE_CURRENT_BINARY_DIR})
17-
18-add_definitions(-DQT_NO_KEYWORDS)
19-
20-add_library(mouse-plugin SHARED mouse-plugin.h mouse-plugin.cpp)
21-qt5_use_modules(mouse-plugin Core Qml DBus)
22-target_link_libraries(mouse-plugin SystemSettings)
23-install(TARGETS mouse-plugin DESTINATION ${PLUGIN_MODULE_DIR})
24
25=== removed file 'plugins/mouse/plugin/mouse-plugin.cpp'
26--- plugins/mouse/plugin/mouse-plugin.cpp 2015-07-30 18:51:21 +0000
27+++ plugins/mouse/plugin/mouse-plugin.cpp 1970-01-01 00:00:00 +0000
28@@ -1,65 +0,0 @@
29-/*
30- * This file is part of system-settings
31- *
32- * Copyright (C) 2015 Canonical Ltd
33- *
34- * Contact: Ken VanDine <ken.vandine@canonical.com>
35- *
36- * This program is free software: you can redistribute it and/or modify it
37- * under the terms of the GNU General Public License version 3, as published
38- * by the Free Software Foundation.
39- *
40- * This program is distributed in the hope that it will be useful, but
41- * WITHOUT ANY WARRANTY; without even the implied warranties of
42- * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
43- * PURPOSE. See the GNU General Public License for more details.
44- *
45- * You should have received a copy of the GNU General Public License along
46- * with this program. If not, see <http://www.gnu.org/licenses/>.
47- */
48-
49-#include "mouse-plugin.h"
50-
51-#include <QDebug>
52-#include <QDBusInterface>
53-#include <QStringList>
54-#include <SystemSettings/ItemBase>
55-
56-using namespace SystemSettings;
57-
58-class MouseItem: public ItemBase
59-{
60- Q_OBJECT
61-
62-public:
63- explicit MouseItem(const QVariantMap &staticData, QObject *parent = 0);
64- void setVisibility(bool visible);
65-
66-};
67-
68-
69-MouseItem::MouseItem(const QVariantMap &staticData, QObject *parent):
70- ItemBase(staticData, parent)
71-{
72- QDBusConnection m_systemBusConnection (QDBusConnection::systemBus());
73- QDBusInterface m_unityInterface ("com.canonical.unity",
74- "/com/canonical/unity",
75- "com.canonical.unity",
76- m_systemBusConnection);
77-
78- /* FIXME: Determine visibility based on connection of mouse or touchpad */
79- setVisibility(true);
80-}
81-
82-void MouseItem::setVisibility(bool visible)
83-{
84- setVisible(visible);
85-}
86-
87-ItemBase *MousePlugin::createItem(const QVariantMap &staticData,
88- QObject *parent)
89-{
90- return new MouseItem(staticData, parent);
91-}
92-
93-#include "mouse-plugin.moc"
94
95=== removed file 'plugins/mouse/plugin/mouse-plugin.h'
96--- plugins/mouse/plugin/mouse-plugin.h 2015-07-30 18:51:21 +0000
97+++ plugins/mouse/plugin/mouse-plugin.h 1970-01-01 00:00:00 +0000
98@@ -1,38 +0,0 @@
99-/*
100- * This file is part of system-settings
101- *
102- * Copyright (C) 2015 Canonical Ltd
103- *
104- * Contact: Ken VanDine <ken.vandine@canonical.com>
105- *
106- * This program is free software: you can redistribute it and/or modify it
107- * under the terms of the GNU General Public License version 3, as published
108- * by the Free Software Foundation.
109- *
110- * This program is distributed in the hope that it will be useful, but
111- * WITHOUT ANY WARRANTY; without even the implied warranties of
112- * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
113- * PURPOSE. See the GNU General Public License for more details.
114- *
115- * You should have received a copy of the GNU General Public License along
116- * with this program. If not, see <http://www.gnu.org/licenses/>.
117- */
118-
119-#ifndef SYSTEM_SETTINGS_MOUSE_PLUGIN_H
120-#define SYSTEM_SETTINGS_MOUSE_PLUGIN_H
121-
122-#include <QObject>
123-#include <SystemSettings/PluginInterface>
124-
125-class MousePlugin: public QObject, public SystemSettings::PluginInterface2
126-{
127- Q_OBJECT
128- Q_PLUGIN_METADATA(IID "com.ubuntu.SystemSettings.PluginInterface/2.0")
129- Q_INTERFACES(SystemSettings::PluginInterface2)
130-
131-public:
132- SystemSettings::ItemBase *createItem(const QVariantMap &staticData,
133- QObject *parent = 0);
134-};
135-
136-#endif // SYSTEM_SETTINGS_MOUSE_PLUGIN_H

Subscribers

People subscribed via source and target branches