Merge lp:~ken-vandine/ubuntu-system-settings/lp1545021 into lp:ubuntu-system-settings

Proposed by Ken VanDine
Status: Merged
Approved by: Bill Filler
Approved revision: 1597
Merged at revision: 1598
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/lp1545021
Merge into: lp:ubuntu-system-settings
Diff against target: 22 lines (+4/-1)
1 file modified
plugins/security-privacy/Location.qml (+4/-1)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/lp1545021
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Touch System Settings Pending
Review via email: mp+285894@code.launchpad.net

Commit message

Don't use the cellular portion of the location accuracy string when there is no modem available

Description of the change

Don't use the cellular portion of the location accuracy string when there is no modem available

To post a comment you must log in.
1597. By Ken VanDine

improved grammar

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
1598. By Ken VanDine

fixed syntax error

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/security-privacy/Location.qml'
2--- plugins/security-privacy/Location.qml 2016-02-04 15:28:51 +0000
3+++ plugins/security-privacy/Location.qml 2016-02-12 21:16:13 +0000
4@@ -24,6 +24,7 @@
5 import QtQuick 2.4
6 import Ubuntu.Components 1.3
7 import Ubuntu.Components.ListItems 1.3 as ListItem
8+import Ubuntu.Connectivity 1.0
9 import Ubuntu.SystemSettings.SecurityPrivacy 1.0
10 import SystemSettings 1.0
11
12@@ -182,7 +183,9 @@
13 terms and conditions reside (typically a qml file).
14 HERE is a Nokia trademark, so it should probably
15 not be translated. */
16- name: i18n.tr("Using GPS, anonymized Wi-Fi and cellular network info.<br>By selecting this option you accept the <a href='%1'>Nokia HERE terms and conditions</a>.").arg("here-terms.qml"),
17+ name: NetworkingStatus.modemAvailable ?
18+ i18n.tr("Using GPS, anonymized Wi-Fi and cellular network info.<br>By selecting this option you accept the <a href='%1'>Nokia HERE terms and conditions</a>.").arg("here-terms.qml") :
19+ i18n.tr("Using GPS and anonymized Wi-Fi info.<br>By selecting this option you accept the <a href='%1'>Nokia HERE terms and conditions</a>.").arg("here-terms.qml"),
20 key: "here"
21 });
22 }

Subscribers

People subscribed via source and target branches