Merge lp:~ken-vandine/ubuntu-system-settings/lp1535827 into lp:ubuntu-system-settings

Proposed by Ken VanDine
Status: Merged
Approved by: Jonas G. Drange
Approved revision: 1584
Merged at revision: 1584
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/lp1535827
Merge into: lp:ubuntu-system-settings
Diff against target: 38 lines (+11/-4)
1 file modified
plugins/bluetooth/PageComponent.qml (+11/-4)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/lp1535827
Reviewer Review Type Date Requested Status
Jonas G. Drange (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+283216@code.launchpad.net

Commit message

Don't display the ActivityIndicator while searching, causes to much load.

Description of the change

Don't display the ActivityIndicator while searching, causes to much load.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

LGTM and works. Thanks!

review: Approve
1585. By Ken VanDine

Display Searching text when discovering, not discoverable

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/bluetooth/PageComponent.qml'
2--- plugins/bluetooth/PageComponent.qml 2015-11-20 08:47:27 +0000
3+++ plugins/bluetooth/PageComponent.qml 2016-01-21 14:21:33 +0000
4@@ -266,14 +266,15 @@
5 enabled: false
6 }
7
8- ActivityIndicator {
9+ Label {
10 anchors {
11 top: parent.top
12 right: parent.right
13 topMargin: units.gu(1)
14 }
15+ color: "darkgrey"
16 visible: backend.powered && !backend.discoverable
17- running: visible
18+ text: i18n.tr("Searching…")
19 }
20 }
21 }
22@@ -319,9 +320,15 @@
23 id: disconnectedHeader
24 text: connectedList.visible ? i18n.tr("Connect another device:") : i18n.tr("Connect a device:")
25 enabled: bluetoothActionGroup.enabled.state != undefined ? bluetoothActionGroup.enabled.state : false
26- control: ActivityIndicator {
27+ control: Label {
28+ anchors {
29+ top: parent.top
30+ right: parent.right
31+ topMargin: units.gu(1)
32+ }
33+ color: "darkgrey"
34 visible: backend.powered && backend.discovering
35- running: visible
36+ text: i18n.tr("Searching…")
37 }
38 }
39

Subscribers

People subscribed via source and target branches