Merge lp:~ken-vandine/ubuntu-system-settings/lp1505663 into lp:ubuntu-system-settings
Proposed by
Ken VanDine
| Status: | Merged |
|---|---|
| Approved by: | Sebastien Bacher |
| Approved revision: | 1548 |
| Merged at revision: | 1551 |
| Proposed branch: | lp:~ken-vandine/ubuntu-system-settings/lp1505663 |
| Merge into: | lp:ubuntu-system-settings |
| Prerequisite: | lp:~gang65/ubuntu-system-settings/ubuntu-system-settings-remove-retry-button |
| Diff against target: |
32 lines (+5/-3) 1 file modified
plugins/system-update/PageComponent.qml (+5/-3) |
| To merge this branch: | bzr merge lp:~ken-vandine/ubuntu-system-settings/lp1505663 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Needs Fixing | |
| Sebastien Bacher (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2015-10-20.
Commit message
Ensure we only check for updates when NetworkingStatu
Description of the change
Ensure we only check for updates when NetworkingStatu
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
thanks, you have a console.warn() in there though, I guess it's a debug leftover?
the onClicked change also needs wrong, shouldn't we rather disable the button instead of having the action showed to the user but not doing that it should?