ubuntu-system-settings

Merge lp:~ken-vandine/ubuntu-system-settings/lp1373462 into lp:ubuntu-system-settings

  1. lp1373462
  2. Merge into trunk
Proposed by Ken VanDine
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 1081
Merged at revision: 1087
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/lp1373462
Merge into: lp:ubuntu-system-settings
Diff against target: 18 lines (+4/-3)
1 file modified
plugins/background/Preview.qml (+4/-3)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/lp1373462
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
Review via email: mp+236017@code.launchpad.net

Commit message

[background] set sourceSize in the image preview to work around an issue
loading large images

Description of the change

[background] set sourceSize in the image preview to work around an issue
loading large images. I also changed it from PreserveAspectFit to PreserveAspectCrop to match what the shell does, it ensures the preview always fills the screen.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

works as described!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/background/Preview.qml'
2--- plugins/background/Preview.qml 2014-09-05 14:00:00 +0000
3+++ plugins/background/Preview.qml 2014-09-25 17:46:25 +0000
4@@ -71,10 +71,11 @@
5
6 Image {
7 id: previewImage
8- anchors.centerIn: parent
9+ anchors.fill: parent
10 source: uri
11- height: parent.height
12- fillMode: Image.PreserveAspectFit
13+ sourceSize.height: height
14+ sourceSize.width: width
15+ fillMode: Image.PreserveAspectCrop
16 }
17
18 ListItem.ThinDivider {

Subscribers

People subscribed via source and target branches