Merge lp:~ken-vandine/ubuntu-system-settings/lp1371810 into lp:ubuntu-system-settings

[Ken VanDine]

Set the version information in the SystemUpdate constructor (LP: #1371810)

Set the version information in the SystemUpdate constructor (LP: #1371810)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1063
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1519/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5068/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3699
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/711
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4817/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6320
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6320/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13559
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3091
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4008
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4008/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1519/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1063
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1521/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5073/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3703
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/713
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4821/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6325
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6325/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13564
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3096
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4014
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4014/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1521/rebuild

review: Needs Fixing (continuous-integration)

[Sebastien Bacher (seb128)]

Could you explain what is happening when the version is not set?

review: Needs Information

[Ken VanDine (ken-vandine)]

This dbus call sets several properties, the getter for those properties all call this method when they aren't set. So we end up with several dbus calls on load.

[Sebastien Bacher (seb128)]

ok, thanks

review: Approve

=== modified file 'plugins/system-update/system_update.cpp'
--- plugins/system-update/system_update.cpp	2014-09-11 20:24:35 +0000
+++ plugins/system-update/system_update.cpp	2014-09-22 18:41:50 +0000
@@ -67,6 +67,8 @@
                 this, SIGNAL(updateFailed(int, QString)));
     connect(&m_SystemServiceIface, SIGNAL(SettingChanged(QString, QString)),
                 this, SLOT(ProcessSettingChanged(QString, QString)));
+
+    setCurrentDetailedVersion();
 }
 
 SystemUpdate::~SystemUpdate() {