Merge lp:~ken-vandine/ubuntu-system-settings/lp1365408 into lp:ubuntu-system-settings

Proposed by Ken VanDine
Status: Merged
Approved by: Ken VanDine
Approved revision: 1052
Merged at revision: 1054
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/lp1365408
Merge into: lp:ubuntu-system-settings
Diff against target: 26 lines (+2/-1)
2 files modified
CMakeLists.txt (+1/-0)
ubuntu-system-settings.desktop.in.in (+1/-1)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/lp1365408
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Mathieu Trudel-Lapierre (community) Approve
Review via email: mp+234764@code.launchpad.net

Commit message

Include an icon instead of using the themed icon (LP: #1365408)

Description of the change

Include an icon instead of using the themed icon (LP: #1365408)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks good!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2014-09-15 13:54:30 +0000
3+++ CMakeLists.txt 2014-09-16 04:24:01 +0000
4@@ -88,6 +88,7 @@
5
6 install(FILES ubuntu-system-settings.url-dispatcher DESTINATION share/url-dispatcher/urls)
7 install(FILES screenshot.png DESTINATION ${SETTINGS_SHARE_DIR})
8+install(FILES system-settings.png DESTINATION ${SETTINGS_SHARE_DIR})
9 install(PROGRAMS push-helper/software_updates_helper.py DESTINATION ${PUSH_HELPER_DIR} RENAME ubuntu-system-settings)
10
11 if(cmake_build_type_lower MATCHES coverage)
12
13=== added file 'system-settings.png'
14Binary files system-settings.png 1970-01-01 00:00:00 +0000 and system-settings.png 2014-09-16 04:24:01 +0000 differ
15=== modified file 'ubuntu-system-settings.desktop.in.in'
16--- ubuntu-system-settings.desktop.in.in 2014-09-11 16:08:04 +0000
17+++ ubuntu-system-settings.desktop.in.in 2014-09-16 04:24:01 +0000
18@@ -2,7 +2,7 @@
19 _Name=System Settings
20 _Categories=System;
21 _Keywords=Preferences;Settings;
22-Icon=system-settings
23+Icon=@SETTINGS_SHARE_DIR@/system-settings.png
24 Exec=system-settings %u
25 Terminal=false
26 Type=Application

Subscribers

People subscribed via source and target branches