Merge lp:~ken-vandine/ubuntu-system-settings/less_phone_specific into lp:ubuntu-system-settings
- less_phone_specific
- Merge into trunk
Status: | Merged |
---|---|
Approved by: | Jonas G. Drange |
Approved revision: | 1523 |
Merged at revision: | 1593 |
Proposed branch: | lp:~ken-vandine/ubuntu-system-settings/less_phone_specific |
Merge into: | lp:ubuntu-system-settings |
Diff against target: |
855 lines (+412/-146) 27 files modified
plugins/about/DevMode.qml (+1/-1) plugins/about/PageComponent.qml (+2/-2) plugins/about/about.settings (+1/-1) plugins/battery/SleepValues.qml (+3/-3) plugins/cellular/CMakeLists.txt (+1/-0) plugins/cellular/Components/NoSim.qml (+1/-1) plugins/cellular/cellular.settings (+2/-1) plugins/cellular/plugin/CMakeLists.txt (+6/-0) plugins/cellular/plugin/cellular-plugin.cpp (+83/-0) plugins/cellular/plugin/cellular-plugin.h (+38/-0) plugins/language/RebootNecessary.qml (+1/-1) plugins/mouse/None.qml (+1/-1) plugins/phone/CMakeLists.txt (+2/-0) plugins/phone/phone.settings (+2/-1) plugins/phone/plugin/CMakeLists.txt (+6/-0) plugins/phone/plugin/phone-plugin.cpp (+83/-0) plugins/phone/plugin/phone-plugin.h (+38/-0) plugins/reset/EraseEverything.qml (+1/-1) plugins/reset/PageComponent.qml (+1/-1) plugins/reset/reset.settings (+1/-1) plugins/security-privacy/Location.qml (+1/-1) plugins/security-privacy/LockSecurity.qml (+2/-2) plugins/security-privacy/PhoneLocking.qml (+1/-1) plugins/security-privacy/SimPin.qml (+1/-1) plugins/sound/PageComponent.qml (+131/-124) plugins/system-update/PageComponent.qml (+1/-1) tests/autopilot/ubuntu_system_settings/tests/test_reset.py (+1/-1) |
To merge this branch: | bzr merge lp:~ken-vandine/ubuntu-system-settings/less_phone_specific |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jonas G. Drange (community) | Approve | ||
PS Jenkins bot | continuous-integration | Needs Fixing | |
Review via email: mp+285078@code.launchpad.net |
Commit message
Make cellular and phone dynamically visible
Description of the change
Make cellular and phone dynamically visible
- 1517. By Ken VanDine
-
String changes to make things less phone specific
- 1518. By Ken VanDine
-
Another "phone" string change
PS Jenkins bot (ps-jenkins) wrote : | # |
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1518
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1519. By Ken VanDine
-
Fixed the reset test to match the string change
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1519
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1519
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1520. By Ken VanDine
-
Changed more Phone strings to Device
- 1521. By Ken VanDine
-
Hide the phone related sounds in the sound panel when there isn't a modem available
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1520
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1521
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
- 1522. By Ken VanDine
-
Hide the "Other Sounds" heading when there aren't other areas
- 1523. By Ken VanDine
-
Don't display the IMEI when there are no modems
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1523
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild:
http://
Jonas G. Drange (jonas-drange) wrote : | # |
LGTM! Thanks
Preview Diff
1 | === modified file 'plugins/about/DevMode.qml' |
2 | --- plugins/about/DevMode.qml 2015-08-10 13:31:45 +0000 |
3 | +++ plugins/about/DevMode.qml 2016-02-05 22:05:53 +0000 |
4 | @@ -81,7 +81,7 @@ |
5 | width: parent.width |
6 | horizontalAlignment: Text.AlignHCenter |
7 | wrapMode: Text.WordWrap |
8 | - text: i18n.tr("In Developer Mode, anyone can access, change or delete anything on this phone by connecting it to another device.") |
9 | + text: i18n.tr("In Developer Mode, anyone can access, change or delete anything on this device by connecting it to another device.") |
10 | } |
11 | } |
12 | } |
13 | |
14 | === modified file 'plugins/about/PageComponent.qml' |
15 | --- plugins/about/PageComponent.qml 2016-01-22 19:57:26 +0000 |
16 | +++ plugins/about/PageComponent.qml 2016-02-05 22:05:53 +0000 |
17 | @@ -32,7 +32,7 @@ |
18 | id: root |
19 | objectName: "aboutPage" |
20 | |
21 | - title: i18n.tr("About this phone") |
22 | + title: i18n.tr("About") |
23 | flickable: scrollWidget |
24 | property var modemsSorted: [] |
25 | |
26 | @@ -109,7 +109,7 @@ |
27 | text: "IMEI" |
28 | value: modemsSorted.length ? (imeiNumber || i18n.tr("None")) : |
29 | i18n.tr("None") |
30 | - visible: modemsSorted.length <= 1 |
31 | + visible: modemsSorted.length == 1 |
32 | } |
33 | |
34 | ListItem.MultiValue { |
35 | |
36 | === modified file 'plugins/about/about.settings' |
37 | --- plugins/about/about.settings 2014-09-24 17:10:03 +0000 |
38 | +++ plugins/about/about.settings 2016-02-05 22:05:53 +0000 |
39 | @@ -1,6 +1,6 @@ |
40 | { |
41 | "icon": "ubuntu-logo-symbolic", |
42 | - "name": "About this phone", |
43 | + "name": "About", |
44 | "translations": "ubuntu-system-settings", |
45 | "category": "uncategorized-bottom", |
46 | "priority": 0, |
47 | |
48 | === modified file 'plugins/battery/SleepValues.qml' |
49 | --- plugins/battery/SleepValues.qml 2015-08-13 13:13:57 +0000 |
50 | +++ plugins/battery/SleepValues.qml 2016-02-05 22:05:53 +0000 |
51 | @@ -75,8 +75,8 @@ |
52 | anchors.right: parent.right |
53 | |
54 | SettingsItemTitle { |
55 | - text: lockOnSuspend ? i18n.tr("Lock the phone when it's not in use:") : |
56 | - i18n.tr("Put the phone to sleep when it is not in use:") |
57 | + text: lockOnSuspend ? i18n.tr("Lock the device when it's not in use:") : |
58 | + i18n.tr("Put the device to sleep when it is not in use:") |
59 | } |
60 | |
61 | ListItem.ItemSelector { |
62 | @@ -122,7 +122,7 @@ |
63 | } |
64 | |
65 | ListItem.Caption { |
66 | - text: lockOnSuspend ? i18n.tr("Shorter times are more secure. Phone won't lock during calls or video playback.") : i18n.tr("Phone won’t sleep during calls or video playback.") |
67 | + text: lockOnSuspend ? i18n.tr("Shorter times are more secure. Device won't lock during calls or video playback.") : i18n.tr("Device won’t sleep during calls or video playback.") |
68 | } |
69 | } |
70 | } |
71 | |
72 | === modified file 'plugins/cellular/CMakeLists.txt' |
73 | --- plugins/cellular/CMakeLists.txt 2015-08-06 15:12:39 +0000 |
74 | +++ plugins/cellular/CMakeLists.txt 2016-02-05 22:05:53 +0000 |
75 | @@ -1,4 +1,5 @@ |
76 | add_subdirectory(Components) |
77 | +add_subdirectory(plugin) |
78 | |
79 | install(FILES cellular.settings DESTINATION ${PLUGIN_MANIFEST_DIR}) |
80 | install(FILES settings-cellular.svg DESTINATION ${PLUGIN_MANIFEST_DIR}/icons) |
81 | |
82 | === modified file 'plugins/cellular/Components/NoSim.qml' |
83 | --- plugins/cellular/Components/NoSim.qml 2015-08-10 13:31:45 +0000 |
84 | +++ plugins/cellular/Components/NoSim.qml 2016-02-05 22:05:53 +0000 |
85 | @@ -42,7 +42,7 @@ |
86 | |
87 | Label { |
88 | anchors { left: parent.left; right: parent.right; } |
89 | - text: i18n.tr("Insert a SIM, then restart the phone.") |
90 | + text: i18n.tr("Insert a SIM, then restart the device.") |
91 | horizontalAlignment: Text.AlignHCenter |
92 | color: UbuntuColors.lightGrey |
93 | wrapMode: Text.WordWrap |
94 | |
95 | === modified file 'plugins/cellular/cellular.settings' |
96 | --- plugins/cellular/cellular.settings 2015-08-13 12:49:29 +0000 |
97 | +++ plugins/cellular/cellular.settings 2016-02-05 22:05:53 +0000 |
98 | @@ -1,4 +1,5 @@ |
99 | { |
100 | + "plugin": "cellular-plugin", |
101 | "icon": "gsm-3g-high", |
102 | "name": "Cellular", |
103 | "translations": "ubuntu-system-settings", |
104 | @@ -23,6 +24,6 @@ |
105 | "sim" |
106 | ], |
107 | "has-dynamic-keywords": false, |
108 | - "has-dynamic-visibility": false, |
109 | + "has-dynamic-visibility": true, |
110 | "page-component": "PageComponent.qml" |
111 | } |
112 | |
113 | === added directory 'plugins/cellular/plugin' |
114 | === added file 'plugins/cellular/plugin/CMakeLists.txt' |
115 | --- plugins/cellular/plugin/CMakeLists.txt 1970-01-01 00:00:00 +0000 |
116 | +++ plugins/cellular/plugin/CMakeLists.txt 2016-02-05 22:05:53 +0000 |
117 | @@ -0,0 +1,6 @@ |
118 | +include_directories(${CMAKE_CURRENT_BINARY_DIR}) |
119 | + |
120 | +add_library(cellular-plugin SHARED cellular-plugin.h cellular-plugin.cpp) |
121 | +qt5_use_modules(cellular-plugin Core Qml DBus) |
122 | +target_link_libraries(cellular-plugin SystemSettings) |
123 | +install(TARGETS cellular-plugin DESTINATION ${PLUGIN_MODULE_DIR}) |
124 | |
125 | === added file 'plugins/cellular/plugin/cellular-plugin.cpp' |
126 | --- plugins/cellular/plugin/cellular-plugin.cpp 1970-01-01 00:00:00 +0000 |
127 | +++ plugins/cellular/plugin/cellular-plugin.cpp 2016-02-05 22:05:53 +0000 |
128 | @@ -0,0 +1,83 @@ |
129 | +/* |
130 | + * This file is part of system-settings |
131 | + * |
132 | + * Copyright (C) 2015 Canonical Ltd. |
133 | + * |
134 | + * Contact: Ken VanDine <ken.vandine@canonical.com> |
135 | + * |
136 | + * This program is free software: you can redistribute it and/or modify it |
137 | + * under the terms of the GNU General Public License version 3, as published |
138 | + * by the Free Software Foundation. |
139 | + * |
140 | + * This program is distributed in the hope that it will be useful, but |
141 | + * WITHOUT ANY WARRANTY; without even the implied warranties of |
142 | + * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR |
143 | + * PURPOSE. See the GNU General Public License for more details. |
144 | + * |
145 | + * You should have received a copy of the GNU General Public License along |
146 | + * with this program. If not, see <http://www.gnu.org/licenses/>. |
147 | + */ |
148 | + |
149 | +#include "cellular-plugin.h" |
150 | + |
151 | +#include <QDebug> |
152 | +#include <QDBusInterface> |
153 | +#include <QDBusPendingReply> |
154 | +#include <QProcessEnvironment> |
155 | +#include <QtDBus> |
156 | +#include <SystemSettings/ItemBase> |
157 | + |
158 | +using namespace SystemSettings; |
159 | + |
160 | +class CellularItem: public ItemBase |
161 | +{ |
162 | + Q_OBJECT |
163 | + |
164 | +public: |
165 | + explicit CellularItem(const QVariantMap &staticData, QObject *parent = 0); |
166 | + void setVisibility(bool visible); |
167 | +}; |
168 | + |
169 | + |
170 | +CellularItem::CellularItem(const QVariantMap &staticData, QObject *parent): |
171 | + ItemBase(staticData, parent) |
172 | +{ |
173 | + QProcessEnvironment env = QProcessEnvironment::systemEnvironment(); |
174 | + if (env.contains(QLatin1String("USS_SHOW_ALL_UI"))) { |
175 | + QString showAllS = env.value("USS_SHOW_ALL_UI", QString()); |
176 | + |
177 | + if(!showAllS.isEmpty()) { |
178 | + setVisibility(true); |
179 | + return; |
180 | + } |
181 | + } |
182 | + |
183 | + bool supportedDevice(true); |
184 | + |
185 | + QDBusInterface m_NetStatusPropertiesIface( |
186 | + "com.ubuntu.connectivity1", |
187 | + "/com/ubuntu/connectivity1/NetworkingStatus", |
188 | + "org.freedesktop.DBus.Properties", |
189 | + QDBusConnection::sessionBus()); |
190 | + QDBusPendingReply<QVariant> modemReply = m_NetStatusPropertiesIface.call( |
191 | + "Get", "com.ubuntu.connectivity1.NetworkingStatus", "ModemAvailable"); |
192 | + modemReply.waitForFinished(); |
193 | + if (modemReply.isValid()) { |
194 | + supportedDevice = modemReply.argumentAt<0>().toBool(); |
195 | + } |
196 | + |
197 | + setVisibility(supportedDevice); |
198 | +} |
199 | + |
200 | +void CellularItem::setVisibility(bool visible) |
201 | +{ |
202 | + setVisible(visible); |
203 | +} |
204 | + |
205 | +ItemBase *CellularPlugin::createItem(const QVariantMap &staticData, |
206 | + QObject *parent) |
207 | +{ |
208 | + return new CellularItem(staticData, parent); |
209 | +} |
210 | + |
211 | +#include "cellular-plugin.moc" |
212 | |
213 | === added file 'plugins/cellular/plugin/cellular-plugin.h' |
214 | --- plugins/cellular/plugin/cellular-plugin.h 1970-01-01 00:00:00 +0000 |
215 | +++ plugins/cellular/plugin/cellular-plugin.h 2016-02-05 22:05:53 +0000 |
216 | @@ -0,0 +1,38 @@ |
217 | +/* |
218 | + * This file is part of system-settings |
219 | + * |
220 | + * Copyright (C) 2015 Canonical Ltd. |
221 | + * |
222 | + * Contact: Ken VanDine <ken.vandine@canonical.com> |
223 | + * |
224 | + * This program is free software: you can redistribute it and/or modify it |
225 | + * under the terms of the GNU General Public License version 3, as published |
226 | + * by the Free Software Foundation. |
227 | + * |
228 | + * This program is distributed in the hope that it will be useful, but |
229 | + * WITHOUT ANY WARRANTY; without even the implied warranties of |
230 | + * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR |
231 | + * PURPOSE. See the GNU General Public License for more details. |
232 | + * |
233 | + * You should have received a copy of the GNU General Public License along |
234 | + * with this program. If not, see <http://www.gnu.org/licenses/>. |
235 | + */ |
236 | + |
237 | +#ifndef SYSTEM_SETTINGS_CELLULAR_PLUGIN_H |
238 | +#define SYSTEM_SETTINGS_CELLULAR_PLUGIN_H |
239 | + |
240 | +#include <QObject> |
241 | +#include <SystemSettings/PluginInterface> |
242 | + |
243 | +class CellularPlugin: public QObject, public SystemSettings::PluginInterface2 |
244 | +{ |
245 | + Q_OBJECT |
246 | + Q_PLUGIN_METADATA(IID "com.ubuntu.SystemSettings.PluginInterface/2.0") |
247 | + Q_INTERFACES(SystemSettings::PluginInterface2) |
248 | + |
249 | +public: |
250 | + SystemSettings::ItemBase *createItem(const QVariantMap &staticData, |
251 | + QObject *parent = 0); |
252 | +}; |
253 | + |
254 | +#endif // SYSTEM_SETTINGS_CELLULAR_PLUGIN_H |
255 | |
256 | === modified file 'plugins/language/RebootNecessary.qml' |
257 | --- plugins/language/RebootNecessary.qml 2015-08-10 13:31:45 +0000 |
258 | +++ plugins/language/RebootNecessary.qml 2016-02-05 22:05:53 +0000 |
259 | @@ -31,7 +31,7 @@ |
260 | signal reboot() |
261 | signal revert(int to) |
262 | |
263 | - text: i18n.tr("The phone needs to restart for changes to take effect.") |
264 | + text: i18n.tr("The device needs to restart for changes to take effect.") |
265 | Button { |
266 | id: reboot |
267 | objectName: "reboot" |
268 | |
269 | === modified file 'plugins/mouse/None.qml' |
270 | --- plugins/mouse/None.qml 2015-12-04 19:17:51 +0000 |
271 | +++ plugins/mouse/None.qml 2016-02-05 22:05:53 +0000 |
272 | @@ -33,7 +33,7 @@ |
273 | if (pocketPC) |
274 | return i18n.tr("Connect a mouse or touchpad via USB, or use a Bluetooth device. If a Bluetooth device isn’t detected, make sure it is turned on and its batteries are charged.") |
275 | else |
276 | - return i18n.tr("You need to use a Bluetooth mouse or touchpad with this display. Make sure it is close to the phone and its batteries are charged.") |
277 | + return i18n.tr("You need to use a Bluetooth mouse or touchpad with this display. Make sure it is close to the device and its batteries are charged.") |
278 | } |
279 | } |
280 | } |
281 | |
282 | === modified file 'plugins/phone/CMakeLists.txt' |
283 | --- plugins/phone/CMakeLists.txt 2015-06-19 18:06:18 +0000 |
284 | +++ plugins/phone/CMakeLists.txt 2016-02-05 22:05:53 +0000 |
285 | @@ -1,3 +1,5 @@ |
286 | +add_subdirectory(plugin) |
287 | + |
288 | set(QML_SOURCES |
289 | CallForwarding.qml |
290 | CallForwardItem.qml |
291 | |
292 | === modified file 'plugins/phone/phone.settings' |
293 | --- plugins/phone/phone.settings 2014-09-24 17:10:03 +0000 |
294 | +++ plugins/phone/phone.settings 2016-02-05 22:05:53 +0000 |
295 | @@ -1,4 +1,5 @@ |
296 | { |
297 | + "plugin": "phone-plugin", |
298 | "icon": "preferences-system-phone-symbolic", |
299 | "name": "Phone", |
300 | "translations": "ubuntu-system-settings", |
301 | @@ -19,5 +20,5 @@ |
302 | ], |
303 | "page-component": "PageComponent.qml", |
304 | "has-dynamic-keywords": false, |
305 | - "has-dynamic-visibility": false |
306 | + "has-dynamic-visibility": true |
307 | } |
308 | |
309 | === added directory 'plugins/phone/plugin' |
310 | === added file 'plugins/phone/plugin/CMakeLists.txt' |
311 | --- plugins/phone/plugin/CMakeLists.txt 1970-01-01 00:00:00 +0000 |
312 | +++ plugins/phone/plugin/CMakeLists.txt 2016-02-05 22:05:53 +0000 |
313 | @@ -0,0 +1,6 @@ |
314 | +include_directories(${CMAKE_CURRENT_BINARY_DIR}) |
315 | + |
316 | +add_library(phone-plugin SHARED phone-plugin.h phone-plugin.cpp) |
317 | +qt5_use_modules(phone-plugin Core Qml DBus) |
318 | +target_link_libraries(phone-plugin SystemSettings) |
319 | +install(TARGETS phone-plugin DESTINATION ${PLUGIN_MODULE_DIR}) |
320 | |
321 | === added file 'plugins/phone/plugin/phone-plugin.cpp' |
322 | --- plugins/phone/plugin/phone-plugin.cpp 1970-01-01 00:00:00 +0000 |
323 | +++ plugins/phone/plugin/phone-plugin.cpp 2016-02-05 22:05:53 +0000 |
324 | @@ -0,0 +1,83 @@ |
325 | +/* |
326 | + * This file is part of system-settings |
327 | + * |
328 | + * Copyright (C) 2015 Canonical Ltd. |
329 | + * |
330 | + * Contact: Ken VanDine <ken.vandine@canonical.com> |
331 | + * |
332 | + * This program is free software: you can redistribute it and/or modify it |
333 | + * under the terms of the GNU General Public License version 3, as published |
334 | + * by the Free Software Foundation. |
335 | + * |
336 | + * This program is distributed in the hope that it will be useful, but |
337 | + * WITHOUT ANY WARRANTY; without even the implied warranties of |
338 | + * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR |
339 | + * PURPOSE. See the GNU General Public License for more details. |
340 | + * |
341 | + * You should have received a copy of the GNU General Public License along |
342 | + * with this program. If not, see <http://www.gnu.org/licenses/>. |
343 | + */ |
344 | + |
345 | +#include "phone-plugin.h" |
346 | + |
347 | +#include <QDebug> |
348 | +#include <QDBusInterface> |
349 | +#include <QDBusPendingReply> |
350 | +#include <QProcessEnvironment> |
351 | +#include <QtDBus> |
352 | +#include <SystemSettings/ItemBase> |
353 | + |
354 | +using namespace SystemSettings; |
355 | + |
356 | +class PhoneItem: public ItemBase |
357 | +{ |
358 | + Q_OBJECT |
359 | + |
360 | +public: |
361 | + explicit PhoneItem(const QVariantMap &staticData, QObject *parent = 0); |
362 | + void setVisibility(bool visible); |
363 | +}; |
364 | + |
365 | + |
366 | +PhoneItem::PhoneItem(const QVariantMap &staticData, QObject *parent): |
367 | + ItemBase(staticData, parent) |
368 | +{ |
369 | + QProcessEnvironment env = QProcessEnvironment::systemEnvironment(); |
370 | + if (env.contains(QLatin1String("USS_SHOW_ALL_UI"))) { |
371 | + QString showAllS = env.value("USS_SHOW_ALL_UI", QString()); |
372 | + |
373 | + if(!showAllS.isEmpty()) { |
374 | + setVisibility(true); |
375 | + return; |
376 | + } |
377 | + } |
378 | + |
379 | + bool supportedDevice(true); |
380 | + |
381 | + QDBusInterface m_NetStatusPropertiesIface( |
382 | + "com.ubuntu.connectivity1", |
383 | + "/com/ubuntu/connectivity1/NetworkingStatus", |
384 | + "org.freedesktop.DBus.Properties", |
385 | + QDBusConnection::sessionBus()); |
386 | + QDBusPendingReply<QVariant> modemReply = m_NetStatusPropertiesIface.call( |
387 | + "Get", "com.ubuntu.connectivity1.NetworkingStatus", "ModemAvailable"); |
388 | + modemReply.waitForFinished(); |
389 | + if (modemReply.isValid()) { |
390 | + supportedDevice = modemReply.argumentAt<0>().toBool(); |
391 | + } |
392 | + |
393 | + setVisibility(supportedDevice); |
394 | +} |
395 | + |
396 | +void PhoneItem::setVisibility(bool visible) |
397 | +{ |
398 | + setVisible(visible); |
399 | +} |
400 | + |
401 | +ItemBase *PhonePlugin::createItem(const QVariantMap &staticData, |
402 | + QObject *parent) |
403 | +{ |
404 | + return new PhoneItem(staticData, parent); |
405 | +} |
406 | + |
407 | +#include "phone-plugin.moc" |
408 | |
409 | === added file 'plugins/phone/plugin/phone-plugin.h' |
410 | --- plugins/phone/plugin/phone-plugin.h 1970-01-01 00:00:00 +0000 |
411 | +++ plugins/phone/plugin/phone-plugin.h 2016-02-05 22:05:53 +0000 |
412 | @@ -0,0 +1,38 @@ |
413 | +/* |
414 | + * This file is part of system-settings |
415 | + * |
416 | + * Copyright (C) 2015 Canonical Ltd. |
417 | + * |
418 | + * Contact: Ken VanDine <ken.vandine@canonical.com> |
419 | + * |
420 | + * This program is free software: you can redistribute it and/or modify it |
421 | + * under the terms of the GNU General Public License version 3, as published |
422 | + * by the Free Software Foundation. |
423 | + * |
424 | + * This program is distributed in the hope that it will be useful, but |
425 | + * WITHOUT ANY WARRANTY; without even the implied warranties of |
426 | + * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR |
427 | + * PURPOSE. See the GNU General Public License for more details. |
428 | + * |
429 | + * You should have received a copy of the GNU General Public License along |
430 | + * with this program. If not, see <http://www.gnu.org/licenses/>. |
431 | + */ |
432 | + |
433 | +#ifndef SYSTEM_SETTINGS_PHONE_PLUGIN_H |
434 | +#define SYSTEM_SETTINGS_PHONE_PLUGIN_H |
435 | + |
436 | +#include <QObject> |
437 | +#include <SystemSettings/PluginInterface> |
438 | + |
439 | +class PhonePlugin: public QObject, public SystemSettings::PluginInterface2 |
440 | +{ |
441 | + Q_OBJECT |
442 | + Q_PLUGIN_METADATA(IID "com.ubuntu.SystemSettings.PluginInterface/2.0") |
443 | + Q_INTERFACES(SystemSettings::PluginInterface2) |
444 | + |
445 | +public: |
446 | + SystemSettings::ItemBase *createItem(const QVariantMap &staticData, |
447 | + QObject *parent = 0); |
448 | +}; |
449 | + |
450 | +#endif // SYSTEM_SETTINGS_PHONE_PLUGIN_H |
451 | |
452 | === modified file 'plugins/reset/EraseEverything.qml' |
453 | --- plugins/reset/EraseEverything.qml 2015-08-10 13:31:45 +0000 |
454 | +++ plugins/reset/EraseEverything.qml 2016-02-05 22:05:53 +0000 |
455 | @@ -38,7 +38,7 @@ |
456 | } |
457 | } |
458 | objectName: "factoryResetDialog" |
459 | - text: i18n.tr("All documents, saved games, settings, and other items will be permanently deleted from this phone.") |
460 | + text: i18n.tr("All documents, saved games, settings, and other items will be permanently deleted from this device.") |
461 | Button { |
462 | id: action |
463 | text: i18n.tr("Erase & Reset Everything") |
464 | |
465 | === modified file 'plugins/reset/PageComponent.qml' |
466 | --- plugins/reset/PageComponent.qml 2015-08-10 13:31:45 +0000 |
467 | +++ plugins/reset/PageComponent.qml 2016-02-05 22:05:53 +0000 |
468 | @@ -29,7 +29,7 @@ |
469 | ItemPage { |
470 | id: root |
471 | |
472 | - title: i18n.tr("Reset phone") |
473 | + title: i18n.tr("Reset device") |
474 | objectName: "resetPage" |
475 | flickable: scrollWidget |
476 | |
477 | |
478 | === modified file 'plugins/reset/reset.settings' |
479 | --- plugins/reset/reset.settings 2014-09-24 17:10:03 +0000 |
480 | +++ plugins/reset/reset.settings 2016-02-05 22:05:53 +0000 |
481 | @@ -1,6 +1,6 @@ |
482 | { |
483 | "icon": "reset", |
484 | - "name": "Reset phone", |
485 | + "name": "Reset", |
486 | "translations": "ubuntu-system-settings", |
487 | "category": "uncategorized-bottom", |
488 | "priority": 1, |
489 | |
490 | === modified file 'plugins/security-privacy/Location.qml' |
491 | --- plugins/security-privacy/Location.qml 2015-09-18 14:18:11 +0000 |
492 | +++ plugins/security-privacy/Location.qml 2016-02-05 22:05:53 +0000 |
493 | @@ -91,7 +91,7 @@ |
494 | anchors.right: parent.right |
495 | |
496 | SettingsItemTitle { |
497 | - text: i18n.tr("Let the phone detect your location:") |
498 | + text: i18n.tr("Let the device detect your location:") |
499 | } |
500 | |
501 | ListItem.ItemSelector { |
502 | |
503 | === modified file 'plugins/security-privacy/LockSecurity.qml' |
504 | --- plugins/security-privacy/LockSecurity.qml 2015-08-10 13:31:45 +0000 |
505 | +++ plugins/security-privacy/LockSecurity.qml 2016-02-05 22:05:53 +0000 |
506 | @@ -35,7 +35,7 @@ |
507 | // The user can still press the main "back" button or other buttons on the |
508 | // page while the "change password" dialog is up. This is because the |
509 | // dialog is not guaranteed to cover the whole screen; consider the case of |
510 | - // turning a phone to landscape mode. We'd rather not have the password |
511 | + // turning a device to landscape mode. We'd rather not have the password |
512 | // changing operation interrupted by destroying the dialog out from under |
513 | // it. So we make sure the whole page and header back button are disabled |
514 | // while the dialog is working. |
515 | @@ -442,7 +442,7 @@ |
516 | anchors.right: parent.right |
517 | |
518 | SettingsItemTitle { |
519 | - text: i18n.tr("Unlock the phone using:") |
520 | + text: i18n.tr("Unlock the device using:") |
521 | } |
522 | |
523 | ListItem.ItemSelector { |
524 | |
525 | === modified file 'plugins/security-privacy/PhoneLocking.qml' |
526 | --- plugins/security-privacy/PhoneLocking.qml 2015-09-18 14:18:11 +0000 |
527 | +++ plugins/security-privacy/PhoneLocking.qml 2016-02-05 22:05:53 +0000 |
528 | @@ -146,7 +146,7 @@ |
529 | |
530 | ListItem.Caption { |
531 | text: securityPrivacy.securityType === UbuntuSecurityPrivacyPanel.Swipe ? |
532 | - i18n.tr("Turn on lock security to restrict access when the phone is locked.") : |
533 | + i18n.tr("Turn on lock security to restrict access when the device is locked.") : |
534 | i18n.tr("Other apps and functions will prompt you to unlock.") |
535 | } |
536 | } |
537 | |
538 | === modified file 'plugins/security-privacy/SimPin.qml' |
539 | --- plugins/security-privacy/SimPin.qml 2015-08-10 13:31:45 +0000 |
540 | +++ plugins/security-privacy/SimPin.qml 2016-02-05 22:05:53 +0000 |
541 | @@ -441,7 +441,7 @@ |
542 | } |
543 | |
544 | ListItem.Caption { |
545 | - text: i18n.tr("When a SIM PIN is set, it must be entered to access cellular services after restarting the phone or swapping the SIM.") |
546 | + text: i18n.tr("When a SIM PIN is set, it must be entered to access cellular services after restarting the device or swapping the SIM.") |
547 | } |
548 | |
549 | ListItem.Caption { |
550 | |
551 | === modified file 'plugins/sound/PageComponent.qml' |
552 | --- plugins/sound/PageComponent.qml 2015-10-23 14:57:26 +0000 |
553 | +++ plugins/sound/PageComponent.qml 2016-02-05 22:05:53 +0000 |
554 | @@ -22,6 +22,7 @@ |
555 | import QtQuick 2.4 |
556 | import Ubuntu.Components 1.3 |
557 | import Ubuntu.Components.ListItems 1.3 as ListItem |
558 | +import Ubuntu.Connectivity 1.0 |
559 | import SystemSettings 1.0 |
560 | import Ubuntu.SystemSettings.Sound 1.0 |
561 | import Ubuntu.Settings.Menus 0.1 as Menus |
562 | @@ -84,10 +85,6 @@ |
563 | text: i18n.tr("Silent Mode") |
564 | } |
565 | |
566 | - SettingsItemTitle { |
567 | - text: i18n.tr("Ringer:") |
568 | - } |
569 | - |
570 | QDBusActionGroup { |
571 | id: soundActionGroup |
572 | busType: DBus.SessionBus |
573 | @@ -101,126 +98,136 @@ |
574 | Component.onCompleted: start() |
575 | } |
576 | |
577 | - Menus.SliderMenu { |
578 | - id: volumeSlider |
579 | - objectName: "sliderMenu" |
580 | - enabled: soundActionGroup.volume.state != null |
581 | - minimumValue: 0.0 |
582 | - maximumValue: 1.0 |
583 | - minIcon: "image://theme/audio-volume-low-zero" |
584 | - maxIcon: "image://theme/audio-volume-high" |
585 | - |
586 | - property real serverValue: soundActionGroup.volume.state |
587 | - |
588 | - USC.ServerPropertySynchroniser { |
589 | - userTarget: volumeSlider |
590 | - userProperty: "value" |
591 | - serverTarget: volumeSlider |
592 | - serverProperty: "serverValue" |
593 | - maximumWaitBufferInterval: 16 |
594 | - |
595 | - onSyncTriggered: soundActionGroup.volume.updateState(value); |
596 | - } |
597 | - } |
598 | - |
599 | - ListItem.Standard { |
600 | - id: highVolumeWarning |
601 | - visible: soundActionGroup.highVolume.state == true |
602 | - text: i18n.tr("High volume can damage your hearing.") |
603 | - } |
604 | - |
605 | - SettingsItemTitle { |
606 | - text: i18n.tr("Phone calls:") |
607 | - } |
608 | - |
609 | - ListItem.SingleValue { |
610 | - text: i18n.tr("Ringtone") |
611 | - value: Utilities.buildDisplayName( |
612 | - backendInfo.incomingCallSound) |
613 | - progression: true |
614 | - onClicked: pageStack.push( |
615 | - Qt.resolvedUrl("SoundsList.qml"), |
616 | - { title: i18n.tr("Ringtone"), |
617 | - showStopButton: true, |
618 | - soundType: 0, |
619 | - soundsDir: |
620 | - "/usr/share/sounds/ubuntu/ringtones/" }) |
621 | - } |
622 | - |
623 | - ListItem.Standard { |
624 | - control: CheckBox { |
625 | - objectName: "callVibrate" |
626 | - property bool serverChecked: backendInfo.incomingCallVibrate |
627 | - onServerCheckedChanged: checked = serverChecked |
628 | - Component.onCompleted: checked = serverChecked |
629 | - onTriggered: backendInfo.incomingCallVibrate = checked |
630 | - } |
631 | - text: i18n.tr("Vibrate on ring") |
632 | - } |
633 | - |
634 | - ListItem.Standard { |
635 | - control: CheckBox { |
636 | - objectName: "callVibrateSilentMode" |
637 | - property bool serverChecked: backendInfo.incomingCallVibrateSilentMode |
638 | - onServerCheckedChanged: checked = serverChecked |
639 | - Component.onCompleted: checked = serverChecked |
640 | - onTriggered: backendInfo.incomingCallVibrateSilentMode = checked |
641 | - } |
642 | - text: i18n.tr("Vibrate in Silent Mode") |
643 | - } |
644 | - |
645 | - ListItem.Standard { |
646 | - control: Switch { |
647 | - objectName: "dialpadSounds" |
648 | - property bool serverChecked: backendInfo.dialpadSoundsEnabled |
649 | - onServerCheckedChanged: checked = serverChecked |
650 | - Component.onCompleted: checked = serverChecked |
651 | - onTriggered: backendInfo.dialpadSoundsEnabled = checked |
652 | - } |
653 | - text: i18n.tr("Dialpad tones") |
654 | - } |
655 | - |
656 | - SettingsItemTitle { |
657 | - text: i18n.tr("Messages:") |
658 | - } |
659 | - |
660 | - ListItem.SingleValue { |
661 | - text: i18n.tr("Message received") |
662 | - value:Utilities.buildDisplayName( |
663 | - backendInfo.incomingMessageSound) |
664 | - progression: true |
665 | - onClicked: pageStack.push( |
666 | - Qt.resolvedUrl("SoundsList.qml"), |
667 | - { title: i18n.tr("Message received"), |
668 | - soundType: 1, |
669 | - soundsDir: |
670 | - "/usr/share/sounds/ubuntu/notifications/" }) |
671 | - } |
672 | - |
673 | - ListItem.Standard { |
674 | - control: CheckBox { |
675 | - objectName: "messageVibrate" |
676 | - property bool serverChecked: backendInfo.incomingMessageVibrate |
677 | - onServerCheckedChanged: checked = serverChecked |
678 | - Component.onCompleted: checked = serverChecked |
679 | - onTriggered: backendInfo.incomingMessageVibrate = checked |
680 | - } |
681 | - text: i18n.tr("Vibrate with message sound") |
682 | - } |
683 | - |
684 | - ListItem.Standard { |
685 | - control: CheckBox { |
686 | - objectName: "messageVibrateSilentMode" |
687 | - property bool serverChecked: backendInfo.incomingMessageVibrateSilentMode |
688 | - onServerCheckedChanged: checked = serverChecked |
689 | - Component.onCompleted: checked = serverChecked |
690 | - onTriggered: backendInfo.incomingMessageVibrateSilentMode = checked |
691 | - } |
692 | - text: i18n.tr("Vibrate in Silent Mode") |
693 | - } |
694 | - |
695 | - SettingsItemTitle { |
696 | - text: i18n.tr("Other sounds:") |
697 | + Column { |
698 | + anchors.left: parent.left |
699 | + anchors.right: parent.right |
700 | + visible: NetworkingStatus.modemAvailable |
701 | + |
702 | + SettingsItemTitle { |
703 | + text: i18n.tr("Ringer:") |
704 | + } |
705 | + |
706 | + Menus.SliderMenu { |
707 | + id: volumeSlider |
708 | + objectName: "sliderMenu" |
709 | + enabled: soundActionGroup.volume.state != null |
710 | + minimumValue: 0.0 |
711 | + maximumValue: 1.0 |
712 | + minIcon: "image://theme/audio-volume-low-zero" |
713 | + maxIcon: "image://theme/audio-volume-high" |
714 | + |
715 | + property real serverValue: soundActionGroup.volume.state |
716 | + |
717 | + USC.ServerPropertySynchroniser { |
718 | + userTarget: volumeSlider |
719 | + userProperty: "value" |
720 | + serverTarget: volumeSlider |
721 | + serverProperty: "serverValue" |
722 | + maximumWaitBufferInterval: 16 |
723 | + |
724 | + onSyncTriggered: soundActionGroup.volume.updateState(value); |
725 | + } |
726 | + } |
727 | + |
728 | + ListItem.Standard { |
729 | + id: highVolumeWarning |
730 | + visible: soundActionGroup.highVolume.state == true |
731 | + text: i18n.tr("High volume can damage your hearing.") |
732 | + } |
733 | + |
734 | + SettingsItemTitle { |
735 | + text: i18n.tr("Phone calls:") |
736 | + } |
737 | + |
738 | + ListItem.SingleValue { |
739 | + text: i18n.tr("Ringtone") |
740 | + value: Utilities.buildDisplayName( |
741 | + backendInfo.incomingCallSound) |
742 | + progression: true |
743 | + onClicked: pageStack.push( |
744 | + Qt.resolvedUrl("SoundsList.qml"), |
745 | + { title: i18n.tr("Ringtone"), |
746 | + showStopButton: true, |
747 | + soundType: 0, |
748 | + soundsDir: |
749 | + "/usr/share/sounds/ubuntu/ringtones/" }) |
750 | + } |
751 | + |
752 | + ListItem.Standard { |
753 | + control: CheckBox { |
754 | + objectName: "callVibrate" |
755 | + property bool serverChecked: backendInfo.incomingCallVibrate |
756 | + onServerCheckedChanged: checked = serverChecked |
757 | + Component.onCompleted: checked = serverChecked |
758 | + onTriggered: backendInfo.incomingCallVibrate = checked |
759 | + } |
760 | + text: i18n.tr("Vibrate on ring") |
761 | + } |
762 | + |
763 | + ListItem.Standard { |
764 | + control: CheckBox { |
765 | + objectName: "callVibrateSilentMode" |
766 | + property bool serverChecked: backendInfo.incomingCallVibrateSilentMode |
767 | + onServerCheckedChanged: checked = serverChecked |
768 | + Component.onCompleted: checked = serverChecked |
769 | + onTriggered: backendInfo.incomingCallVibrateSilentMode = checked |
770 | + } |
771 | + text: i18n.tr("Vibrate in Silent Mode") |
772 | + } |
773 | + |
774 | + ListItem.Standard { |
775 | + control: Switch { |
776 | + objectName: "dialpadSounds" |
777 | + property bool serverChecked: backendInfo.dialpadSoundsEnabled |
778 | + onServerCheckedChanged: checked = serverChecked |
779 | + Component.onCompleted: checked = serverChecked |
780 | + onTriggered: backendInfo.dialpadSoundsEnabled = checked |
781 | + } |
782 | + text: i18n.tr("Dialpad tones") |
783 | + } |
784 | + |
785 | + SettingsItemTitle { |
786 | + text: i18n.tr("Messages:") |
787 | + } |
788 | + |
789 | + ListItem.SingleValue { |
790 | + text: i18n.tr("Message received") |
791 | + value:Utilities.buildDisplayName( |
792 | + backendInfo.incomingMessageSound) |
793 | + progression: true |
794 | + onClicked: pageStack.push( |
795 | + Qt.resolvedUrl("SoundsList.qml"), |
796 | + { title: i18n.tr("Message received"), |
797 | + soundType: 1, |
798 | + soundsDir: |
799 | + "/usr/share/sounds/ubuntu/notifications/" }) |
800 | + } |
801 | + |
802 | + ListItem.Standard { |
803 | + control: CheckBox { |
804 | + objectName: "messageVibrate" |
805 | + property bool serverChecked: backendInfo.incomingMessageVibrate |
806 | + onServerCheckedChanged: checked = serverChecked |
807 | + Component.onCompleted: checked = serverChecked |
808 | + onTriggered: backendInfo.incomingMessageVibrate = checked |
809 | + } |
810 | + text: i18n.tr("Vibrate with message sound") |
811 | + } |
812 | + |
813 | + ListItem.Standard { |
814 | + control: CheckBox { |
815 | + objectName: "messageVibrateSilentMode" |
816 | + property bool serverChecked: backendInfo.incomingMessageVibrateSilentMode |
817 | + onServerCheckedChanged: checked = serverChecked |
818 | + Component.onCompleted: checked = serverChecked |
819 | + onTriggered: backendInfo.incomingMessageVibrateSilentMode = checked |
820 | + } |
821 | + text: i18n.tr("Vibrate in Silent Mode") |
822 | + } |
823 | + |
824 | + SettingsItemTitle { |
825 | + text: i18n.tr("Other sounds:") |
826 | + } |
827 | } |
828 | |
829 | ListItem.Standard { |
830 | |
831 | === modified file 'plugins/system-update/PageComponent.qml' |
832 | --- plugins/system-update/PageComponent.qml 2015-12-16 16:19:04 +0000 |
833 | +++ plugins/system-update/PageComponent.qml 2016-02-05 22:05:53 +0000 |
834 | @@ -94,7 +94,7 @@ |
835 | Dialog { |
836 | id: dialogueInstall |
837 | title: i18n.tr("Update System") |
838 | - text: root.batterySafeForUpdate ? i18n.tr("The phone needs to restart to install the system update.") : i18n.tr("Connect the phone to power before installing the system update.") |
839 | + text: root.batterySafeForUpdate ? i18n.tr("The device needs to restart to install the system update.") : i18n.tr("Connect the device to power before installing the system update.") |
840 | |
841 | Button { |
842 | text: i18n.tr("Restart & Install") |
843 | |
844 | === modified file 'tests/autopilot/ubuntu_system_settings/tests/test_reset.py' |
845 | --- tests/autopilot/ubuntu_system_settings/tests/test_reset.py 2014-10-01 14:43:09 +0000 |
846 | +++ tests/autopilot/ubuntu_system_settings/tests/test_reset.py 2016-02-05 22:05:53 +0000 |
847 | @@ -29,7 +29,7 @@ |
848 | """Checks whether Reset page is available""" |
849 | self.assertThat( |
850 | self.reset_page.title, |
851 | - Equals(_('Reset phone'))) |
852 | + Equals(_('Reset device'))) |
853 | |
854 | def test_reset_launcher(self): |
855 | gsettings = Gio.Settings.new('com.canonical.Unity.Launcher') |
FAILED: Continuous integration, rev:1516 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- ci/2597/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- vivid-touch/ 6338 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- vivid-amd64- ci/371 jenkins. qa.ubuntu. com/job/ ubuntu- system- settings- vivid-i386- ci/780 jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- vivid-touch/ 4866 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 6349 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- vivid-armhf/ 6349/artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 27326
http://
Executed test runs:
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- system- settings- ci/2597/ rebuild
http://