ubuntu-system-settings

Merge lp:~ken-vandine/ubuntu-system-settings/keywords into lp:ubuntu-system-settings

  1. keywords
  2. Merge into trunk
Proposed by Ken VanDine
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 1066
Merged at revision: 1084
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/keywords
Merge into: lp:ubuntu-system-settings
Diff against target: 331 lines (+113/-21)
18 files modified
plugins/about/about.settings (+15/-1)
plugins/accessibility/accessibility.settings (+1/-2)
plugins/background/background.settings (+5/-1)
plugins/battery/battery.settings (+6/-1)
plugins/bluetooth/bluetooth.settings (+10/-1)
plugins/brightness/brightness.settings (+4/-1)
plugins/cellular/cellular.settings (+9/-1)
plugins/flight-mode/flight-mode.settings (+3/-1)
plugins/language/language.settings (+11/-3)
plugins/notifications/notifications.settings (+9/-1)
plugins/orientation-lock/orientation-lock.settings (+2/-1)
plugins/phone/phone.settings (+7/-1)
plugins/reset/reset.settings (+4/-1)
plugins/security-privacy/security-privacy.settings (+9/-1)
plugins/sound/sound.settings (+7/-1)
plugins/system-update/system-update.settings (+5/-1)
plugins/time-date/time-date.settings (+1/-1)
plugins/wifi/wifi.settings (+5/-1)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/keywords
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+235737@code.launchpad.net

Commit message

Provide more keywords to make search useful (LP: #1370219)

Description of the change

Provide more keywords to make search useful (LP: #1370219)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1064
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1533/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5119/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3728
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/725
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4864/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6371
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6371/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13632
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3119
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4039
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4039/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1533/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks, looks fine, why do we need to add "settings" to all the panels though?

review: Needs Information
lp:~ken-vandine/ubuntu-system-settings/keywords updated
1065. By Ken VanDine

removed redundant "settings" keyword

1066. By Ken VanDine

merged trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1066
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1549/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/5152
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/3757
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/741
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4898
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6404
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/6404/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13700
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3145
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4068
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4068/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1549/rebuild

review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/about/about.settings'
2--- plugins/about/about.settings 2014-04-09 13:38:34 +0000
3+++ plugins/about/about.settings 2014-09-24 17:11:17 +0000
4@@ -7,7 +7,21 @@
5 "keywords": [
6 "about",
7 "device",
8- "info"
9+ "info",
10+ "phone",
11+ "number",
12+ "imei",
13+ "serial",
14+ "address",
15+ "mac",
16+ "licenses",
17+ "developer",
18+ "software",
19+ "storage",
20+ "disk",
21+ "space",
22+ "version",
23+ "revision"
24 ],
25 "has-dynamic-keywords": false,
26 "has-dynamic-visibility": false,
27
28=== modified file 'plugins/accessibility/accessibility.settings'
29--- plugins/accessibility/accessibility.settings 2014-04-09 13:38:34 +0000
30+++ plugins/accessibility/accessibility.settings 2014-09-24 17:11:17 +0000
31@@ -6,8 +6,7 @@
32 "priority": 4,
33 "keywords": [
34 "accessibility",
35- "a11y",
36- "settings"
37+ "a11y"
38 ],
39 "has-dynamic-keywords": false,
40 "has-dynamic-visibility": false
41
42=== modified file 'plugins/background/background.settings'
43--- plugins/background/background.settings 2014-04-09 13:38:34 +0000
44+++ plugins/background/background.settings 2014-09-24 17:11:17 +0000
45@@ -7,7 +7,11 @@
46 "keywords": [
47 "appearance",
48 "background",
49- "wallpaper"
50+ "wallpaper",
51+ "art",
52+ "photo",
53+ "picture",
54+ "image"
55 ],
56 "has-dynamic-keywords": false,
57 "has-dynamic-visibility": false,
58
59=== modified file 'plugins/battery/battery.settings'
60--- plugins/battery/battery.settings 2014-04-09 13:38:34 +0000
61+++ plugins/battery/battery.settings 2014-09-24 17:11:17 +0000
62@@ -7,7 +7,12 @@
63 "priority": 0,
64 "keywords": [
65 "battery",
66- "power"
67+ "power",
68+ "charge",
69+ "idle",
70+ "lock",
71+ "disable",
72+ "enable"
73 ],
74 "has-dynamic-keywords": false,
75 "has-dynamic-visibility": true,
76
77=== modified file 'plugins/bluetooth/bluetooth.settings'
78--- plugins/bluetooth/bluetooth.settings 2014-04-09 13:38:34 +0000
79+++ plugins/bluetooth/bluetooth.settings 2014-09-24 17:11:17 +0000
80@@ -6,7 +6,16 @@
81 "priority": 2,
82 "keywords": [
83 "bluetooth",
84- "settings"
85+ "headset",
86+ "pair",
87+ "device",
88+ "discover",
89+ "car",
90+ "handsfree",
91+ "wireless",
92+ "connect",
93+ "disconnect",
94+ "stereo"
95 ],
96 "has-dynamic-keywords": false,
97 "has-dynamic-visibility": false,
98
99=== modified file 'plugins/brightness/brightness.settings'
100--- plugins/brightness/brightness.settings 2014-04-09 13:38:34 +0000
101+++ plugins/brightness/brightness.settings 2014-09-24 17:11:17 +0000
102@@ -7,7 +7,10 @@
103 "priority": 1,
104 "keywords": [
105 "brightness",
106- "settings"
107+ "display",
108+ "screen",
109+ "automatic",
110+ "adjust"
111 ],
112 "has-dynamic-keywords": false,
113 "has-dynamic-visibility": true,
114
115=== modified file 'plugins/cellular/cellular.settings'
116--- plugins/cellular/cellular.settings 2014-04-09 13:38:34 +0000
117+++ plugins/cellular/cellular.settings 2014-09-24 17:11:17 +0000
118@@ -12,7 +12,15 @@
119 "network",
120 "mobile",
121 "gsm",
122- "settings"
123+ "data",
124+ "carrier",
125+ "4g",
126+ "3g",
127+ "2g",
128+ "lte",
129+ "apn",
130+ "roam",
131+ "sim"
132 ],
133 "has-dynamic-keywords": false,
134 "has-dynamic-visibility": false,
135
136=== modified file 'plugins/flight-mode/flight-mode.settings'
137--- plugins/flight-mode/flight-mode.settings 2014-07-09 10:08:27 +0000
138+++ plugins/flight-mode/flight-mode.settings 2014-09-24 17:11:17 +0000
139@@ -7,7 +7,9 @@
140 "keywords": [
141 "flight",
142 "plane",
143- "offline"
144+ "offline",
145+ "airplane",
146+ "network"
147 ],
148 "has-dynamic-keywords": false,
149 "has-dynamic-visibility": false,
150
151=== modified file 'plugins/language/language.settings'
152--- plugins/language/language.settings 2014-04-09 13:38:34 +0000
153+++ plugins/language/language.settings 2014-09-24 17:11:17 +0000
154@@ -6,9 +6,17 @@
155 "priority": 2,
156 "keywords": [
157 "language",
158- "lang",
159- "i18n",
160- "settings"
161+ "keyboard",
162+ "spellcheck",
163+ "automatic",
164+ "correct",
165+ "suggestions",
166+ "capitalization",
167+ "punctuation",
168+ "layout",
169+ "display",
170+ "words",
171+ "vibration"
172 ],
173 "has-dynamic-keywords": false,
174 "has-dynamic-visibility": false,
175
176=== modified file 'plugins/notifications/notifications.settings'
177--- plugins/notifications/notifications.settings 2014-07-30 14:30:56 +0000
178+++ plugins/notifications/notifications.settings 2014-09-24 17:11:17 +0000
179@@ -7,7 +7,15 @@
180 "keywords": [
181 "software",
182 "notifications",
183- "settings"
184+ "apps",
185+ "authorize",
186+ "alerts",
187+ "permissions",
188+ "badges",
189+ "facebook",
190+ "twitter",
191+ "flickr",
192+ "gmail"
193 ],
194 "has-dynamic-keywords": false,
195 "has-dynamic-visibility": false,
196
197=== modified file 'plugins/orientation-lock/orientation-lock.settings'
198--- plugins/orientation-lock/orientation-lock.settings 2014-08-21 16:07:15 +0000
199+++ plugins/orientation-lock/orientation-lock.settings 2014-09-24 17:11:17 +0000
200@@ -12,7 +12,8 @@
201 "rotation",
202 "orientation",
203 "lock",
204- "screen"
205+ "screen",
206+ "apps"
207 ],
208 "has-dynamic-keywords": false,
209 "has-dynamic-visibility": false,
210
211=== modified file 'plugins/phone/phone.settings'
212--- plugins/phone/phone.settings 2014-07-09 13:17:47 +0000
213+++ plugins/phone/phone.settings 2014-09-24 17:11:17 +0000
214@@ -9,7 +9,13 @@
215 ],
216 "keywords": [
217 "phone",
218- "settings"
219+ "services",
220+ "forwarding",
221+ "waiting",
222+ "call",
223+ "dialpad",
224+ "shortcuts",
225+ "numbers"
226 ],
227 "page-component": "PageComponent.qml",
228 "has-dynamic-keywords": false,
229
230=== modified file 'plugins/reset/reset.settings'
231--- plugins/reset/reset.settings 2014-08-07 14:21:04 +0000
232+++ plugins/reset/reset.settings 2014-09-24 17:11:17 +0000
233@@ -6,7 +6,10 @@
234 "priority": 1,
235 "keywords": [
236 "reset",
237- "settings"
238+ "erase",
239+ "factory",
240+ "clear",
241+ "restore"
242 ],
243 "has-dynamic-keywords": false,
244 "has-dynamic-visibility": false,
245
246=== modified file 'plugins/security-privacy/security-privacy.settings'
247--- plugins/security-privacy/security-privacy.settings 2014-04-09 13:38:34 +0000
248+++ plugins/security-privacy/security-privacy.settings 2014-09-24 17:11:17 +0000
249@@ -7,7 +7,15 @@
250 "keywords": [
251 "security",
252 "privacy",
253- "settings"
254+ "lock",
255+ "sim",
256+ "pin",
257+ "code",
258+ "password",
259+ "passphrase",
260+ "swipe",
261+ "allow",
262+ "access"
263 ],
264 "has-dynamic-keywords": false,
265 "has-dynamic-visibility": false,
266
267=== modified file 'plugins/sound/sound.settings'
268--- plugins/sound/sound.settings 2014-04-09 13:38:34 +0000
269+++ plugins/sound/sound.settings 2014-09-24 17:11:17 +0000
270@@ -6,7 +6,13 @@
271 "priority": 1,
272 "keywords": [
273 "sound",
274- "settings"
275+ "silent",
276+ "ringtone",
277+ "vibrate",
278+ "dialpad",
279+ "message",
280+ "keyboard",
281+ "volume"
282 ],
283 "has-dynamic-keywords": false,
284 "has-dynamic-visibility": false,
285
286=== modified file 'plugins/system-update/system-update.settings'
287--- plugins/system-update/system-update.settings 2014-04-09 13:38:34 +0000
288+++ plugins/system-update/system-update.settings 2014-09-24 17:11:17 +0000
289@@ -8,7 +8,11 @@
290 "system",
291 "software",
292 "update",
293- "settings"
294+ "apps",
295+ "automatic",
296+ "download",
297+ "upgrade",
298+ "click"
299 ],
300 "has-dynamic-keywords": false,
301 "has-dynamic-visibility": false,
302
303=== modified file 'plugins/time-date/time-date.settings'
304--- plugins/time-date/time-date.settings 2014-04-09 13:38:34 +0000
305+++ plugins/time-date/time-date.settings 2014-09-24 17:11:17 +0000
306@@ -8,7 +8,7 @@
307 "time",
308 "date",
309 "timezone",
310- "settings"
311+ "automatic"
312 ],
313 "page-component": "PageComponent.qml",
314 "has-dynamic-keywords": false,
315
316=== modified file 'plugins/wifi/wifi.settings'
317--- plugins/wifi/wifi.settings 2014-04-09 13:38:34 +0000
318+++ plugins/wifi/wifi.settings 2014-09-24 17:11:17 +0000
319@@ -12,7 +12,11 @@
320 "wireless",
321 "wifi",
322 "wi-fi",
323- "settings"
324+ "connect",
325+ "disconnect",
326+ "hidden",
327+ "ip",
328+ "address"
329 ],
330 "has-dynamic-keywords": false,
331 "has-dynamic-visibility": false,

Subscribers

People subscribed via source and target branches