Merge lp:~ken-vandine/ubuntu-system-settings/drop_default_string_hack into lp:ubuntu-system-settings

Proposed by Ken VanDine on 2016-04-05
Status: Merged
Approved by: Ken VanDine on 2016-04-15
Approved revision: 1632
Merged at revision: 1637
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/drop_default_string_hack
Merge into: lp:ubuntu-system-settings
Diff against target: 23 lines (+2/-4)
1 file modified
plugins/mouse/Connected.qml (+2/-4)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/drop_default_string_hack
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing on 2016-04-06
Ubuntu Touch System Settings 2016-04-05 Pending
Review via email: mp+291022@code.launchpad.net

Commit Message

Dropped workaround for lack of default value for MousePrimaryButton and TouchpadPrimaryButton.

Description of the Change

Dropped workaround for lack of default value for MousePrimaryButton and TouchpadPrimaryButton. This was fixed in https://code.launchpad.net/~mterry/gsettings-ubuntu-touch-schemas/fix-strings/+merge/291019

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/mouse/Connected.qml'
2--- plugins/mouse/Connected.qml 2016-03-11 03:12:58 +0000
3+++ plugins/mouse/Connected.qml 2016-04-05 17:33:44 +0000
4@@ -196,8 +196,7 @@
5 right: parent.right
6 }
7 height: childrenRect.height + units.gu(2)
8- // Workaround an issue in AccountsService not returning default for string
9- selected: backend.mousePrimaryButton ? backend.mousePrimaryButton : "left"
10+ selected: backend.mousePrimaryButton
11 onSelectedChanged: {
12 backend.mousePrimaryButton = selected;
13 }
14@@ -369,8 +368,7 @@
15 right: parent.right
16 }
17 height: childrenRect.height + units.gu(1)
18- // Workaround an issue in AccountsService not returning default for string
19- selected: backend.touchpadPrimaryButton ? backend.touchpadPrimaryButton : "left"
20+ selected: backend.touchpadPrimaryButton
21 onSelectedChanged: {
22 backend.touchpadPrimaryButton = selected;
23 }

Subscribers

People subscribed via source and target branches