Merge lp:~ken-vandine/ubuntu-system-settings/app_permissions_online_accounts into lp:ubuntu-system-settings

Proposed by Ken VanDine on 2015-09-09
Status: Merged
Approved by: Alberto Mardegan on 2015-09-09
Approved revision: 1522
Merged at revision: 1521
Proposed branch: lp:~ken-vandine/ubuntu-system-settings/app_permissions_online_accounts
Merge into: lp:ubuntu-system-settings
Prerequisite: lp:~seb128/ubuntu-system-settings/security-ui-tweaks
Diff against target: 20 lines (+5/-5)
1 file modified
plugins/security-privacy/AppAccess.qml (+5/-5)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings/app_permissions_online_accounts
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing on 2015-09-09
Alberto Mardegan 2015-09-09 Approve on 2015-09-09
Review via email: mp+270548@code.launchpad.net

Commit Message

Pass some args when pushing the online-accounts panel page

Description of the Change

Pass some args when pushing the online-accounts panel page

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/security-privacy/AppAccess.qml'
2--- plugins/security-privacy/AppAccess.qml 2015-09-09 15:03:50 +0000
3+++ plugins/security-privacy/AppAccess.qml 2015-09-09 15:03:50 +0000
4@@ -97,11 +97,11 @@
5 text: i18n.tr("Online Accounts…")
6 width: parent.width - units.gu(4)
7 onClicked: {
8- var upPlugin = pluginManager.getByName("online-accounts")
9- if (upPlugin) {
10- var updatePage = upPlugin.pageComponent
11- if (updatePage)
12- pageStack.push(updatePage)
13+ var oaPlugin = pluginManager.getByName("online-accounts")
14+ if (oaPlugin) {
15+ var accountsPage = oaPlugin.pageComponent
16+ if (accountsPage)
17+ pageStack.push(accountsPage, {plugin: oaPlugin, pluginManager: pluginManager})
18 else
19 console.warn("online-accounts")
20 } else {

Subscribers

People subscribed via source and target branches