Merge lp:~ken-vandine/ubuntu-system-settings-online-accounts/keywords into lp:ubuntu-system-settings-online-accounts

Proposed by Ken VanDine
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 187
Merged at revision: 194
Proposed branch: lp:~ken-vandine/ubuntu-system-settings-online-accounts/keywords
Merge into: lp:ubuntu-system-settings-online-accounts
Diff against target: 24 lines (+13/-1)
1 file modified
system-settings-plugin/online-accounts.settings (+13/-1)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-system-settings-online-accounts/keywords
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+235738@code.launchpad.net

Commit message

Provide more keywords to make search useful (LP: #1370219)

Description of the change

Provide more keywords to make search useful (LP: #1370219)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Looks good. Ideally, we should use the dynamic keywords feature to list add all the available providers (and maybe even the account names) as keywords, but I filed that as a new bug (bug 1373279) because that's not as urgent.

review: Approve
188. By Ken VanDine

removed redundant "settings" keyword

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'system-settings-plugin/online-accounts.settings'
2--- system-settings-plugin/online-accounts.settings 2014-08-12 15:27:05 +0000
3+++ system-settings-plugin/online-accounts.settings 2014-09-24 19:05:45 +0000
4@@ -7,7 +7,19 @@
5 "keywords": [
6 "accounts",
7 "online",
8- "login"
9+ "login",
10+ "services",
11+ "social",
12+ "feeds",
13+ "access",
14+ "authorize",
15+ "revoke",
16+ "web",
17+ "facebook",
18+ "twitter",
19+ "flickr",
20+ "google",
21+ "gmail"
22 ],
23 "has-dynamic-keywords": true,
24 "has-dynamic-visibility": false,

Subscribers

People subscribed via source and target branches