Merge lp:~ken-vandine/ubuntu-app-launch/ual_focus_app into lp:ubuntu-app-launch

[Ken VanDine]

Adds Application::Instance::focus and Application::findInstance(pid_t) API

Adds Application::Instance::focus and Application::findInstance(pid_t) API

No tests yet and ubuntu-app-focus is just for my testing, i'll remove it later.

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:322
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/201/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1595/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1602
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1380/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1380/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1380/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1380/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1380/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1380/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/201/rebuild

review: Needs Fixing (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

PASSED: Continuous integration, rev:323
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/202/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1596
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1603
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1381
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1381/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1381
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1381/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1381
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1381/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1381
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1381/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1381
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1381/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1381
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1381/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/202/rebuild

review: Approve (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

PASSED: Continuous integration, rev:324
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/203/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1598
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1605
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1383
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1383/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1383
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1383/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1383
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1383/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1383
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1383/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1383
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1383/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1383
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1383/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/203/rebuild

review: Approve (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

PASSED: Continuous integration, rev:325
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/205/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1611
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1618
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1396
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1396/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1396
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1396/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1396
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1396/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1396
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1396/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1396
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1396/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1396
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1396/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/205/rebuild

review: Approve (continuous-integration)

[Ted Gould (ted)]

A few pointers, I imagine returning the wrong signal is your issue though:

* You don't need an implementation of findInstance() for every subclass. One in Base:: would work for every subclass because it'd use that subclass' instances() function.

* I think you implemented ::focus for Jobs::Upstart as well as Jobs::Base, which means it's probably not being used. (and will go away soon)

* Registry::appFocused returns appResumed()

* I would add a focused to ubuntu-app-watch, makes debugging this stuff easier.

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:327
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/206/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1635/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1642/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/206/rebuild

review: Needs Fixing (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:328
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/207/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1636/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1643/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/207/rebuild

review: Needs Fixing (continuous-integration)

[Ken VanDine (ken-vandine)]

> A few pointers, I imagine returning the wrong signal is your issue though:
>
> * You don't need an implementation of findInstance() for every subclass. One
> in Base:: would work for every subclass because it'd use that subclass'
> instances() function.

Done

> * I think you implemented ::focus for Jobs::Upstart as well as Jobs::Base,
> which means it's probably not being used. (and will go away soon)
>
> * Registry::appFocused returns appResumed()

Fixed

> * I would add a focused to ubuntu-app-watch, makes debugging this stuff
> easier.

Done

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:329
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/208/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1643/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1650/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/208/rebuild

review: Needs Fixing (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

PASSED: Continuous integration, rev:330
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/209/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1644
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1651
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1426
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1426/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1426
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1426/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1426
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1426/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1426
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1426/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1426
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1426/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1426
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1426/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/209/rebuild

review: Approve (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:332
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/210/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1646/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1653
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1428/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1428
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1428/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1428/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1428
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1428/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1428/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1428
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1428/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/210/rebuild

review: Needs Fixing (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:333
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/211/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1647/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1654
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1429/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1429
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1429/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1429/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1429
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1429/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1429/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1429
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1429/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/211/rebuild

review: Needs Fixing (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:334
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/214/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1650/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1657
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1432/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1432
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1432/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1432/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1432
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1432/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1432/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1432
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1432/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/214/rebuild

review: Needs Fixing (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:335
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/215/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1651/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1658
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1433/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1433
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1433/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1433/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1433
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1433/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1433/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1433
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1433/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/215/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ken-vandine/ubuntu-app-launch/ual_focus_app]

337. By Ken VanDine on 2017-02-08

merged prereq

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:336
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/217/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1653/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1660
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1435
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1435/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1435
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1435/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1435/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1435
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1435/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1435
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1435/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1435
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1435/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/217/rebuild

review: Needs Fixing (continuous-integration)

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:337
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/219/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1655/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1662
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1437/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1437/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1437/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1437/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1437/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1437/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/219/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ken-vandine/ubuntu-app-launch/ual_focus_app]

338. By Ken VanDine on 2017-02-09

Added Breaks/Replaces for libubuntu-app-launch2-dev

339. By Ken VanDine on 2017-02-09

merged prereq

340. By Ken VanDine on 2017-02-10

Removed the last of ApplicationFocused

[Ted Gould (ted)]

review: Approve

[unity-api-1-bot (unity-api-1-bot)]

FAILED: Continuous integration, rev:338
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/220/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build/1661/console
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1668
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/1443/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/1443/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/1443/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/1443/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/1443/console
    FAILURE: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/1443/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-ubuntu-app-launch-ci/220/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'libubuntu-app-launch/application-impl-base.cpp'
--- libubuntu-app-launch/application-impl-base.cpp	2017-01-27 20:43:28 +0000
+++ libubuntu-app-launch/application-impl-base.cpp	2017-02-10 15:30:01 +0000
@@ -121,6 +121,18 @@
     }
 }
 
+std::shared_ptr<Application::Instance> Base::findInstance(const pid_t& pid)
+{
+    for (auto instance : instances())
+    {
+        if (instance->hasPid(pid))
+        {
+            return instance;
+        }
+    }
+    return nullptr;
+}
+
 }  // namespace app_impls
 }  // namespace app_launch
 }  // namespace ubuntu

=== modified file 'libubuntu-app-launch/application-impl-base.h'
--- libubuntu-app-launch/application-impl-base.h	2017-01-26 22:33:36 +0000
+++ libubuntu-app-launch/application-impl-base.h	2017-02-10 15:30:01 +0000
@@ -47,6 +47,7 @@
 
     std::string getInstance(const std::shared_ptr<app_info::Desktop>& desktop) const;
     virtual std::shared_ptr<Application::Instance> findInstance(const std::string& instanceid) = 0;
+    std::shared_ptr<Application::Instance> findInstance(const pid_t& pid);
 
 protected:
     /** Pointer to the registry so we can ask it for things */

=== modified file 'libubuntu-app-launch/application.h'
--- libubuntu-app-launch/application.h	2016-08-17 15:24:30 +0000
+++ libubuntu-app-launch/application.h	2017-02-10 15:30:01 +0000
@@ -251,6 +251,8 @@
         /** Stop, or send SIGTERM, to the PIDs in this Application::Instance, if
             the PIDs do not respond to the SIGTERM they will be SIGKILL'd */
         virtual void stop() = 0;
+        /** Signal the shell to focus the Application::Instance */
+        virtual void focus() = 0;
     };
 
     /** A quick check to see if this application has any running instances */
@@ -269,6 +271,12 @@
         \param urls A list of URLs to pass to the application command line
     */
     virtual std::shared_ptr<Instance> launchTest(const std::vector<URL>& urls = {}) = 0;
+
+    /** Get a a pointer to the running instances of this application based on the pid
+
+        \param pid The pid to find the instance of
+    */
+    virtual std::shared_ptr<Instance> findInstance(const pid_t& pid) = 0;
 };
 
 }  // namespace app_launch

=== modified file 'libubuntu-app-launch/jobs-base.cpp'
--- libubuntu-app-launch/jobs-base.cpp	2017-01-26 22:46:06 +0000
+++ libubuntu-app-launch/jobs-base.cpp	2017-02-10 15:30:01 +0000
@@ -497,6 +497,37 @@
     pidListToDbus(registry_, appId_, instance_, pids, "ApplicationResumed");
 }
 
+/** Focuses this application by sending SIGCONT to all the PIDs in the
+    cgroup and tells the Shell to focus the application. */
+void Base::focus()
+{
+    g_debug("Focusing application: %s", std::string(appId_).c_str());
+
+    GError* error = nullptr;
+    GVariantBuilder params;
+    g_variant_builder_init(&params, G_VARIANT_TYPE_TUPLE);
+    g_variant_builder_add_value(&params, g_variant_new_string(std::string(appId_).c_str()));
+    g_variant_builder_add_value(&params, g_variant_new_string(instance_.c_str()));
+    g_dbus_connection_emit_signal(registry_->impl->_dbus.get(),    /* bus */
+                                  nullptr,                         /* destination */
+                                  "/",                             /* path */
+                                  "com.canonical.UbuntuAppLaunch", /* interface */
+                                  "UnityFocusRequest",             /* signal */
+                                  g_variant_builder_end(&params),  /* params */
+                                  &error);                         /* error */
+
+    if (error != nullptr)
+    {
+        g_warning("Unable to emit signal 'UnityFocusRequest' for appid '%s': '%s'", std::string(appId_).c_str(),
+                  error->message);
+        g_error_free(error);
+    }
+    else
+    {
+        g_debug("Emmitted 'UnityFocusRequest' to DBus");
+    }
+}
+
 /** Go through the list of PIDs calling a function and handling
     the issue with getting PIDs being a racey condition.
 

=== modified file 'libubuntu-app-launch/jobs-base.h'
--- libubuntu-app-launch/jobs-base.h	2017-01-26 22:46:06 +0000
+++ libubuntu-app-launch/jobs-base.h	2017-02-10 15:30:01 +0000
@@ -49,6 +49,7 @@
     bool hasPid(pid_t pid) override;
     void pause() override;
     void resume() override;
+    void focus() override;
 
     /* OOM Functions */
     void setOomAdjustment(const oom::Score score) override;