Merge lp:~ken-vandine/ubuntu-app-launch/pkgsync into lp:ubuntu-app-launch/14.04

Proposed by Ken VanDine
Status: Merged
Approved by: Ted Gould
Approved revision: 99
Merged at revision: 100
Proposed branch: lp:~ken-vandine/ubuntu-app-launch/pkgsync
Merge into: lp:ubuntu-app-launch/14.04
Diff against target: 33 lines (+14/-1)
2 files modified
debian/changelog (+14/-0)
debian/control (+0/-1)
To merge this branch: bzr merge lp:~ken-vandine/ubuntu-app-launch/pkgsync
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ted Gould (community) Approve
Review via email: mp+199519@code.launchpad.net

Commit message

* Multi-Arch: same libraries must not depend on run-time application,
  since this breaks cross-compilation. Furthermore, circular
  dependencies are never needed: upstart-app-launch depends on
  libupstart-app-launch2, which depends on upstart-app-launch. It's the
  same reasoning why we do not make libgtk-3.0 depend on epiphany
  webbrowser, even though gtk has functions to open URL in a
  webbrowser. And in a multi-arch world libgtk-3.0 would never know
  which architecture your web-browser is, it could be any. Libraries
  should only ever depend on other linked shared libraries.

Description of the change

Merged packaging changes already uploaded to trusty

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-12-09 12:48:18 +0000
3+++ debian/changelog 2013-12-18 18:15:17 +0000
4@@ -1,3 +1,17 @@
5+upstart-app-launch (0.3+14.04.20131209-0ubuntu3) trusty; urgency=low
6+
7+ * Multi-Arch: same libraries must not depend on run-time application,
8+ since this breaks cross-compilation. Furthermore, circular
9+ dependencies are never needed: upstart-app-launch depends on
10+ libupstart-app-launch2, which depends on upstart-app-launch. It's the
11+ same reasoning why we do not make libgtk-3.0 depend on epiphany
12+ webbrowser, even though gtk has functions to open URL in a
13+ webbrowser. And in a multi-arch world libgtk-3.0 would never know
14+ which architecture your web-browser is, it could be any. Libraries
15+ should only ever depend on other linked shared libraries.
16+
17+ -- Dimitri John Ledkov <xnox@ubuntu.com> Thu, 12 Dec 2013 22:32:34 +0000
18+
19 upstart-app-launch (0.3+14.04.20131209-0ubuntu2) trusty; urgency=low
20
21 * Restrict on which arch we build url-dispatcher due to the ust build-dep
22
23=== modified file 'debian/control'
24--- debian/control 2013-12-09 13:18:08 +0000
25+++ debian/control 2013-12-18 18:15:17 +0000
26@@ -54,7 +54,6 @@
27 Architecture: any
28 Depends: ${misc:Depends},
29 ${shlibs:Depends},
30- upstart-app-launch (= ${binary:Version}),
31 Pre-Depends: ${misc:Pre-Depends},
32 Multi-Arch: same
33 Description: library for sending requests to the upstart app launch

Subscribers

People subscribed via source and target branches