Merge lp:~ken-vandine/signon-ui/lp1231691_spacing into lp:signon-ui

Proposed by Ken VanDine
Status: Rejected
Rejected by: Ken VanDine
Proposed branch: lp:~ken-vandine/signon-ui/lp1231691_spacing
Merge into: lp:signon-ui
Prerequisite: lp:~mardy/signon-ui/lp1231691
Diff against target: 37 lines (+13/-6)
1 file modified
src/browser-process/webview.qml (+13/-6)
To merge this branch: bzr merge lp:~ken-vandine/signon-ui/lp1231691_spacing
Reviewer Review Type Date Requested Status
Online Accounts Pending
Review via email: mp+189870@code.launchpad.net

Commit message

Put the cancel button in a ListItem to ensure consistent spacing with
other elements in system-settings.

Description of the change

Put the cancel button in a ListItem to ensure consistent spacing with
other elements in system-settings.

To post a comment you must log in.

Unmerged revisions

115. By Ken VanDine

Put the cancel button in a ListItem to ensure consistent spacing with
other elements in system-settings.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/browser-process/webview.qml'
2--- src/browser-process/webview.qml 2013-10-08 08:13:04 +0000
3+++ src/browser-process/webview.qml 2013-10-08 14:34:57 +0000
4@@ -3,6 +3,7 @@
5 import QtWebKit 3.0
6 import QtWebKit.experimental 1.0
7 import Ubuntu.Components 0.1
8+import Ubuntu.Components.ListItems 0.1 as ListItem
9 import Ubuntu.Unity.Action 1.0 as UnityActions
10
11 import "ua-overrides.js" as Overrides
12@@ -73,13 +74,19 @@
13 onUrlChanged: request.currentUrl = url
14 }
15
16- Button {
17+ ListItem.SingleControl {
18 id: cancelButton
19- anchors.bottom: parent.bottom
20- anchors.horizontalCenter: parent.horizontalCenter
21- text: i18n.dtr("ubuntu-system-settings-online-accounts", "Cancel")
22- width: parent.width - units.gu(4)
23- onClicked: request.cancel()
24+ anchors {
25+ left: parent.left
26+ right: parent.right
27+ bottom: parent.bottom
28+ }
29+ control: Button {
30+ text: i18n.dtr("ubuntu-system-settings-online-accounts", "Cancel")
31+ width: parent.width - units.gu(4)
32+ onClicked: request.cancel()
33+ }
34+ showDivider: false
35 }
36
37 KeyboardRectangle {

Subscribers

People subscribed via source and target branches

to all changes: