Merge lp:~ken-vandine/share-app/mainview into lp:share-app

Proposed by Ken VanDine
Status: Merged
Approved by: Bill Filler
Approved revision: 49
Merged at revision: 48
Proposed branch: lp:~ken-vandine/share-app/mainview
Merge into: lp:share-app
Prerequisite: lp:~sil2100/share-app/rename_libhud-qt_and_hud1
Diff against target: 68 lines (+14/-5)
4 files modified
debian/changelog (+7/-1)
debian/rules (+3/-0)
main.qml (+2/-2)
tests/autopilot/share_app/emulators/main_window.py (+2/-2)
To merge this branch: bzr merge lp:~ken-vandine/share-app/mainview
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Bill Filler (community) Approve
Review via email: mp+160720@code.launchpad.net

This proposal supersedes a proposal from 2013-04-20.

Commit message

* Ported to use MainView
 * run unit tests during build

Description of the change

 * Ported to use MainView
 * run unit tests during build

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:49
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~ken-vandine/share-app/mainview/+merge/160720/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/share-app-ci/23/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-amd64-ci/4
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/23
        deb: http://jenkins.qa.ubuntu.com/job/share-app-raring-armhf-ci/23/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-raring-i386-ci/23

Click here to trigger a rebuild:
http://s-jenkins:8080/job/share-app-ci/23/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-04-12 14:52:59 +0000
3+++ debian/changelog 2013-04-24 17:36:28 +0000
4@@ -3,9 +3,15 @@
5 * Clean up packaging
6 * Fixed autopilot tests, pointing_device is now available as the mouse
7 property which was expected for the tests.
8+ * Updated for Ubuntu.HUD 1.0
9+ * Ported to use MainView
10 * Automatic snapshot from revision 43 (bootstrap)
11+ * debian/rules
12+ - run unit tests during build
13+ * debian/control
14+ - depend on libhud-qt-qml >= 0.1.0
15
16- -- Ken VanDine <ken.vandine@canonical.com> Tue, 09 Apr 2013 09:53:37 -0400
17+ -- Ken VanDine <ken.vandine@canonical.com> Fri, 19 Apr 2013 23:22:44 -0400
18
19 share-app (0.11) quantal; urgency=low
20
21
22=== modified file 'debian/rules'
23--- debian/rules 2013-02-07 15:05:33 +0000
24+++ debian/rules 2013-04-24 17:36:28 +0000
25@@ -9,6 +9,9 @@
26 %:
27 dh $@ --parallel
28
29+override_dh_auto_test:
30+ make -C obj-$(DEB_HOST_GNU_TYPE) test
31+
32 override_dh_install:
33 dh_install --fail-missing
34
35
36=== modified file 'main.qml'
37--- main.qml 2013-04-24 17:36:28 +0000
38+++ main.qml 2013-04-24 17:36:28 +0000
39@@ -20,9 +20,9 @@
40 import Friends 0.1
41 import Ubuntu.HUD 1.0 as HUD
42
43-Rectangle {
44+MainView {
45 id: shareApp
46- objectName: "root"
47+ objectName: "shareApp"
48 width: units.gu(40)
49 height: units.gu(80)
50
51
52=== modified file 'tests/autopilot/share_app/emulators/main_window.py'
53--- tests/autopilot/share_app/emulators/main_window.py 2013-01-31 20:14:41 +0000
54+++ tests/autopilot/share_app/emulators/main_window.py 2013-04-24 17:36:28 +0000
55@@ -13,11 +13,11 @@
56
57 def get_qml_view(self):
58 """Get the main QML view"""
59- return self.app.select_single("QQuickView")
60+ return self.app.select_single("MainView")
61
62 def get_root(self):
63 """Returns the root item of the scene."""
64- return self.app.select_single("QQuickRectangle", objectName="root")
65+ return self.app.select_single("MainView", objectName="shareApp")
66
67 def get_cancel_button(self):
68 """Returns the cancel button."""

Subscribers

People subscribed via source and target branches