Merge lp:~ken-vandine/share-app/feedback into lp:share-app

[Ken VanDine]

provide some feedback to the user that the upload is in progress and disable the post button during upload

provide some feedback to the user that the upload is in progress and disable the post button during upload

[lp:~ken-vandine/share-app/feedback]

54. By Ken VanDine on 2013-06-06

disable the Post button while an upload is in progress

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:54
http://jenkins.qa.ubuntu.com/job/share-app-ci/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-saucy-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-saucy-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/share-app-saucy-armhf-ci/1/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-saucy-i386-ci/1
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1940

Click here to trigger a rebuild:
http://s-jenkins:8080/job/share-app-ci/26/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:54
http://jenkins.qa.ubuntu.com/job/share-app-ci/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-saucy-amd64-ci/1
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-saucy-armhf-ci/1
        deb: http://jenkins.qa.ubuntu.com/job/share-app-saucy-armhf-ci/1/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-saucy-i386-ci/1
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1940

Click here to trigger a rebuild:
http://s-jenkins:8080/job/share-app-ci/26/rebuild

review: Needs Fixing (continuous-integration)

[lp:~ken-vandine/share-app/feedback]

55. By Ken VanDine on 2013-06-07

added depends for qtdeclarative5-accounts-plugin

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:55
http://jenkins.qa.ubuntu.com/job/share-app-ci/28/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-saucy-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-saucy-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/share-app-saucy-armhf-ci/3/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/share-app-saucy-i386-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1968

Click here to trigger a rebuild:
http://s-jenkins:8080/job/share-app-ci/28/rebuild

review: Approve (continuous-integration)

[Bill Filler (bfiller)]

approved

review: Approve

=== modified file 'debian/control'
--- debian/control	2013-04-24 17:34:10 +0000
+++ debian/control	2013-06-07 14:50:36 +0000
@@ -26,6 +26,7 @@
 Architecture: i386 amd64 armhf
 Depends: ${shlibs:Depends},
          ${misc:Depends},
+         qtdeclarative5-accounts-plugin,
          qtdeclarative5-ubuntu-ui-toolkit-plugin | qt-components-ubuntu,
          qtdeclarative5-hud1.0,
          qtdeclarative5-qtquick2-plugin,

=== modified file 'main.qml'
--- main.qml	2013-05-29 15:38:30 +0000
+++ main.qml	2013-06-07 14:50:36 +0000
@@ -41,6 +41,7 @@
     FriendsDispatcher {
         id: friends
         onUploadComplete: {
+             activitySpinner.visible = false;
              if (success) {
                  notifyOSD.notify("Your photo has been uploaded", null, "facebook");
              } else {
@@ -181,6 +182,13 @@
             focus: true
         }
 
+        ActivityIndicator {
+            id: activitySpinner
+            anchors.centerIn: message
+            visible: false
+            running: visible
+        }
+
         UbuntuShape {
             id: snapshot
             anchors.top: parent.top
@@ -226,7 +234,9 @@
             color: "#dd4814"
             width: units.gu(10)
             height: units.gu(4)
+            enabled: !activitySpinner.visible
             onClicked: {
+                activitySpinner.visible = true;
                 friends.uploadForAccountAsync(fileToShare.account,
                                               "file://" + resizer.resizedFile,
                                               message.text)