Merge lp:~ken-vandine/pidgin-libnotify/indicate.patch into lp:~ted/pidgin-libnotify/indicate.patch

[Ken VanDine]

[Ken VanDine (ken-vandine)]

This forces the buddy list to always be shown when selected in the indicator

[Ted Gould (ted)]

On Thu, 2009-04-02 at 18:45 +0000, Ken VanDine wrote:
> This forces the buddy list to always be shown when selected in the indicator

I guess for me, I think toggling makes more sense. This is what the
notification icon did. Why should the indicator applet be different?

[Ken VanDine (ken-vandine)]

The first time you click it, it toggles it hidden if it is open but not focused. I really think clicking it means I want to see it. Also, evolution indicator always shows the window, never toggles.

[Matthew Paul Thomas (mpt)]

Certainly if the window is opened but not focused, choosing the menu item should focus it -- and fixing that is more important than whatever it does if the window is already focused.

I'm ambivalent on what it should do if the window is already focused. "Switch to" and "minimize" aren't obvious opposites, but on the other hand the window list buttons have long had the same behavior.

[Ted Gould (ted)]

I guess my thoughts on this is that for Jaunty we should mimic the behavior of the notification icon that Pidgin has otherwise. It will hide if visible, and show if hiden or obstructed by other windows. I'm not sure this is the "correct" behavior but I think that it creates a bridge for users from the old notification area function to what we do next. I think the big thing is that every application in the messaging menu should behave in the same way -- which isn't the way it is today. It'd be hard for us to have that consistency in Jaunty.

=== modified file 'src/pidgin-libnotify.c'
--- src/pidgin-libnotify.c	2009-03-30 17:47:39 +0000
+++ src/pidgin-libnotify.c	2009-04-02 18:41:01 +0000
@@ -901,7 +901,7 @@
 		visibility_managed = TRUE;
 	}
 
-	pidgin_blist_toggle_visibility();
+	purple_blist_set_visible(TRUE);
 }
 
 static gboolean