Merge lp:~ken-vandine/mediaplayer-app/nodisplay into lp:mediaplayer-app

Proposed by Ken VanDine on 2017-03-07
Status: Needs review
Proposed branch: lp:~ken-vandine/mediaplayer-app/nodisplay
Merge into: lp:mediaplayer-app
Diff against target: 19 lines (+2/-2)
2 files modified
data/mediaplayer-app.desktop.in.in (+1/-1)
setup/gui/mediaplayer-app.desktop (+1/-1)
To merge this branch: bzr merge lp:~ken-vandine/mediaplayer-app/nodisplay
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Approve on 2017-03-13
Andrew Hayzen (community) 2017-03-07 Approve on 2017-03-07
Review via email: mp+319212@code.launchpad.net

Commit message

Use NoDisplay=true instead of the OnlyShowIn=Old hack, it breaks with the latest ubuntu-app-launch.

Description of the change

Use NoDisplay=true instead of the OnlyShowIn=Old hack, it breaks with the latest ubuntu-app-launch.

To post a comment you must log in.
Andrew Hayzen (ahayzen) wrote :

LGTM, this removes the errors when running the content-hub-peer-hook-wrapper and prevents it from being shown in the app drawer

review: Approve

PASSED: Continuous integration, rev:441
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/2/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build/2309
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/2308
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2130/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=zesty/2130/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2130/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=zesty/2130/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial+overlay/2130/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2130
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=zesty/2130/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-mediaplayer-app-ci/2/rebuild

review: Approve (continuous-integration)

Unmerged revisions

441. By Ken VanDine on 2017-03-07

Use NoDisplay=true instead of the OnlyShowIn=Old hack, it breaks with the latest ubuntu-app-launch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/mediaplayer-app.desktop.in.in'
2--- data/mediaplayer-app.desktop.in.in 2016-11-23 22:58:39 +0000
3+++ data/mediaplayer-app.desktop.in.in 2017-03-07 14:32:27 +0000
4@@ -12,4 +12,4 @@
5 X-Ubuntu-Gettext-Domain=mediaplayer-app
6 X-Ubuntu-Single-Instance=true
7 X-Ubuntu-Default-Department-ID=sound-video
8-OnlyShowIn=Old
9+NoDisplay=true
10
11=== modified file 'setup/gui/mediaplayer-app.desktop'
12--- setup/gui/mediaplayer-app.desktop 2016-11-22 15:30:06 +0000
13+++ setup/gui/mediaplayer-app.desktop 2017-03-07 14:32:27 +0000
14@@ -171,4 +171,4 @@
15 X-Ubuntu-Gettext-Domain=mediaplayer-app
16 X-Ubuntu-Single-Instance=true
17 X-Ubuntu-Default-Department-ID=sound-video
18-OnlyShowIn=Old
19+NoDisplay=true

Subscribers

People subscribed via source and target branches